fix: DH-17599: Fix table name validation#2403
Merged
vbabich merged 4 commits intodeephaven:mainfrom Apr 2, 2025
Merged
Conversation
vbabich
requested review from
a team and
dgodinez-dh
and removed request for
a team
vbabich
changed the title
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes table name validation by replacing client-side name sanitization with a proper regular expression that matches the server-side validation rules.
- Introduces TABLE_NAME_PATTERN for table name validation.
- Updates isValidTableName to use the new regex.
- Improves the test coverage by iterating over a set of invalid table names.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| packages/utils/src/DbNameValidator.ts | Adds TABLE_NAME_PATTERN and updates table name validation |
| packages/utils/src/DbNameValidator.test.ts | Revises tests for invalid table names |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
dgodinez-dh
approved these changes
Apr 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #2398 allowed hyphens in namespace and table names. However, I noticed that server-side validation rejects names starting with a hyphen, while these names appear valid on the client-side.
io.deephaven.db.tables.utils.DBNameValidatoruses separate regular expressions to sanitize and validate names. This change adds the correctTABLE_NAME_PATTERNfor table name validation instead of checking if the name matches its sanitized version.