Skip to content

feat: DH-19632: Add shortcuts to cycle stacks and panels#2458

Merged
gzh2003 merged 2 commits intodeephaven:mainfrom
gzh2003:DH-19632-add-shortcuts-to-cycle-stacks-and-panels
Jun 20, 2025
Merged

feat: DH-19632: Add shortcuts to cycle stacks and panels#2458
gzh2003 merged 2 commits intodeephaven:mainfrom
gzh2003:DH-19632-add-shortcuts-to-cycle-stacks-and-panels

Conversation

@gzh2003
Copy link
Copy Markdown
Contributor

@gzh2003 gzh2003 commented Jun 10, 2025

Part of DH-19632. Introduces keyboard navigation to cycle between and within stacks. Navigating through shortcuts activates content items and respects any existing active selections.

Ctrl + ' / Ctrl + ;: to cycle forward/backward between different stacks in the layout
Ctrl + Shift + ' / Ctrl + Shift + ;: to cycle forward/backward between tabs within the currently focused stack

Changes:

  • CreateNavigationEvent system
  • Implement stack and tab cycling handlers in PanelManager
  • Add getFocusedStack() and getFocusedStackIndex() helper methods to LayoutUtils for focus detection
  • Add forceFocus parameter that bypasses the normal isFocusonShow check

@gzh2003 gzh2003 requested a review from mofojed June 10, 2025 14:44
@gzh2003 gzh2003 self-assigned this Jun 10, 2025
@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 10, 2025

Codecov Report

Attention: Patch coverage is 16.27907% with 72 lines in your changes missing coverage. Please review.

Project coverage is 47.28%. Comparing base (431c057) to head (c516474).
Report is 15 commits behind head on main.

Files with missing lines Patch % Lines
packages/dashboard/src/PanelManager.ts 16.66% 45 Missing ⚠️
packages/code-studio/src/main/AppMainContainer.tsx 0.00% 16 Missing ⚠️
packages/dashboard/src/layout/LayoutUtils.ts 0.00% 10 Missing ⚠️
...es/components/src/shortcuts/NavigationShortcuts.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2458      +/-   ##
==========================================
+ Coverage   47.21%   47.28%   +0.06%     
==========================================
  Files         718      729      +11     
  Lines       39620    39919     +299     
  Branches     9914    10181     +267     
==========================================
+ Hits        18706    18875     +169     
- Misses      20903    20990      +87     
- Partials       11       54      +43     
Flag Coverage Δ
unit 47.28% <16.27%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Comment thread packages/components/src/shortcuts/NavigationShortcuts.ts
Comment thread packages/dashboard/src/layout/LayoutUtils.ts
Comment thread packages/dashboard/src/PanelManager.ts Outdated
Comment thread packages/dashboard/src/PanelEvent.ts Outdated
Comment thread packages/components/src/shortcuts/NavigationShortcuts.ts
Comment thread packages/code-studio/src/main/AppMainContainer.tsx
Comment thread packages/components/src/shortcuts/NavigationShortcuts.ts Outdated
@gzh2003 gzh2003 marked this pull request as draft June 17, 2025 19:32
@gzh2003 gzh2003 force-pushed the DH-19632-add-shortcuts-to-cycle-stacks-and-panels branch from ca830f3 to 412dc5c Compare June 19, 2025 14:47
@gzh2003 gzh2003 marked this pull request as ready for review June 19, 2025 15:19
@gzh2003 gzh2003 requested a review from mofojed June 19, 2025 15:19
@gzh2003 gzh2003 force-pushed the DH-19632-add-shortcuts-to-cycle-stacks-and-panels branch from f3ac859 to c516474 Compare June 19, 2025 18:31
Comment thread packages/dashboard/src/NavigationEvent.ts
@gzh2003 gzh2003 merged commit 97098f2 into deephaven:main Jun 20, 2025
12 checks passed
@gzh2003 gzh2003 deleted the DH-19632-add-shortcuts-to-cycle-stacks-and-panels branch June 20, 2025 16:08
@github-actions github-actions Bot locked and limited conversation to collaborators Jun 20, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants