feat: DH-19632: Add shortcuts to cycle stacks and panels#2458
Merged
gzh2003 merged 2 commits intodeephaven:mainfrom Jun 20, 2025
Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2458 +/- ##
==========================================
+ Coverage 47.21% 47.28% +0.06%
==========================================
Files 718 729 +11
Lines 39620 39919 +299
Branches 9914 10181 +267
==========================================
+ Hits 18706 18875 +169
- Misses 20903 20990 +87
- Partials 11 54 +43
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
gzh2003
commented
Jun 10, 2025
mofojed
requested changes
Jun 11, 2025
mofojed
requested changes
Jun 11, 2025
ca830f3 to
412dc5c
Compare
f3ac859 to
c516474
Compare
mofojed
approved these changes
Jun 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of DH-19632. Introduces keyboard navigation to cycle between and within stacks. Navigating through shortcuts activates content items and respects any existing active selections.
Ctrl + '/Ctrl + ;: to cycle forward/backward between different stacks in the layoutCtrl + Shift + '/Ctrl + Shift + ;: to cycle forward/backward between tabs within the currently focused stackChanges:
NavigationEventsystemPanelManagergetFocusedStack()andgetFocusedStackIndex()helper methods toLayoutUtilsfor focus detectionforceFocusparameter that bypasses the normalisFocusonShowcheck