fix: DH-20036: Skip totalsConfig updates during model transitions to prevent stale column errors#2645
Merged
gzh2003 merged 2 commits intodeephaven:mainfrom Mar 26, 2026
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2645 +/- ##
==========================================
+ Coverage 49.48% 49.76% +0.28%
==========================================
Files 772 774 +2
Lines 43738 43864 +126
Branches 11066 11106 +40
==========================================
+ Hits 21643 21831 +188
+ Misses 22077 22015 -62
Partials 18 18
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
bmingles
approved these changes
Mar 26, 2026
Contributor
bmingles
left a comment
bmingles
left a comment
There was a problem hiding this comment.
Changes look good. I also verified that the error no longer shows up.
gzh2003
deleted the
DH-20036-completely-removing-a-rollup-that-had-an-aggregation-applied-throws-an-internal-error-in-the-cs-console
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For DH-20036. Fixes a bug where removing a rollup group while keeping an aggregation (like CountDistinct) causes an error.