Skip to content

fix: DH-20036: Skip totalsConfig updates during model transitions to prevent stale column errors #2645

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gzh2003 merged 2 commits into from
Mar 26, 2026
+10 −1
Merged

fix: DH-20036: Skip totalsConfig updates during model transitions to prevent stale column errors #2645

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6769ff3
detect model switch in progress
gzh2003 Mar 26, 2026
cf4bd5a
move to proxy
gzh2003 Mar 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion packages/iris-grid/src/IrisGridProxyModel.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ import IrisGridTableModel from './IrisGridTableModel';
import IrisGridPartitionedTableModel from './IrisGridPartitionedTableModel';
import IrisGridTreeTableModel from './IrisGridTreeTableModel';
import IrisGridModel from './IrisGridModel';
import { type ColumnName } from './CommonTypes';
import { type ColumnName, type UITotalsTableConfig } from './CommonTypes';
import { isIrisGridTableModelTemplate } from './IrisGridTableModelTemplate';
import {
type PartitionConfig,
Expand Down Expand Up @@ -431,6 +431,15 @@ class IrisGridProxyModel extends IrisGridModel implements PartitionedGridModel {
this.setNextModel(modelPromise);
}

set totalsConfig(totalsConfig: UITotalsTableConfig | null) {
if (this.modelPromise != null) {
// Model switch in progress. Don't forward, as the config may reference stale columns.
// COLUMNS_CHANGED will reapply the correct config after.
return;
}
this.model.totalsConfig = totalsConfig;
}

get isFilterRequired(): boolean {
return this.originalModel.isFilterRequired;
}
Expand Down
Loading
⚡