Skip to content

Improved getting_started redirect#6456

Closed
Faldrian wants to merge 1 commit intodiaspora:developfrom
Faldrian:6416-fixed-getting-started
Closed

Improved getting_started redirect#6456
Faldrian wants to merge 1 commit intodiaspora:developfrom
Faldrian:6416-fixed-getting-started

Conversation

@Faldrian
Copy link
Copy Markdown
Contributor

@Faldrian Faldrian commented Oct 4, 2015

Only redirect users with getting_started active to the getting_started page if they have not made changes there (avatar, tags). The display of getting-started-hints on the stream is unaffected by this.

Solves #6416.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about current_user.basic_profile_present?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding a new method to the profile model?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

user model, but yes.

@Faldrian Faldrian force-pushed the 6416-fixed-getting-started branch from 10b4aef to 03473e7 Compare October 4, 2015 18:21
Comment thread app/models/user.rb Outdated
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Redundant self detected.

@Faldrian Faldrian force-pushed the 6416-fixed-getting-started branch from 03473e7 to 04e2f5c Compare October 4, 2015 18:24
@Faldrian
Copy link
Copy Markdown
Contributor Author

Faldrian commented Oct 7, 2015

Travis: 7/8 ... so the usual hiccup. :)

@jhass
Copy link
Copy Markdown
Member

jhass commented Oct 7, 2015

Merged as a946251

Thanks!

@jhass jhass closed this in a946251 Oct 7, 2015
@jhass jhass added this to the 0.5.4.0 milestone Oct 7, 2015
@Faldrian Faldrian deleted the 6416-fixed-getting-started branch October 7, 2015 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants