fix: detect logged-in user home directory when running as root#8
Merged
fix: detect logged-in user home directory when running as root#8
Conversation
django23
force-pushed
the
fix/root-service-home
branch
from
096398f to
74e8a13
Compare
When asimov runs as root (via brew services or sudo), ~ expands to /var/root. Now detects the console user via stat/dscl and uses their home directory instead. Addresses stevegrunwell#72.
django23
force-pushed
the
fix/root-service-home
branch
from
a21b2f2 to
0ca062e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
brew servicesorsudo), detect the logged-in user's home directory instead of using/var/rootstat -f '%Su' /dev/consoleto find the console user anddsclto resolve their home directory~if detection failsAddresses stevegrunwell#72, props @Mahoney.
Test plan
make check)