fix issue 39: Score is 0 when a token is in exactly 50% of the documents.#40
Open
danerlt wants to merge 2 commits intodorianbrown:masterfrom
Open
fix issue 39: Score is 0 when a token is in exactly 50% of the documents.#40danerlt wants to merge 2 commits intodorianbrown:masterfrom
danerlt wants to merge 2 commits intodorianbrown:masterfrom
Conversation
danerlt
commented
May 24, 2024
danerlt
commented
fix idf is 0 when a token is in exactly 50% of the documents.
Author
|
@dorianbrown Can you help me review the code, please? Thank you. |
Owner
|
@danerlt Sure thing, I'll have time to take a look sometime in the next week. Looking forward to it 👍 |
Owner
|
I think this is a problem that needs addressing, and from what I can tell there are two ways to go (see this PR for some of the thoughts I just shared), so either fix the epsilon approach and keep the IDF as is, or remove that negativity checking, and go for this "smoothed" IDF function. I'm not working on this topic as intensively as before, but do you know if there's a reason to prefer one of the two from a ranking perspective? Computationally the changed IDF function seems preferable. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.