Skip to content

fix issue 39: Score is 0 when a token is in exactly 50% of the documents. #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
danerlt wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix issue 39: Score is 0 when a token is in exactly 50% of the documents. #40

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4f55e98
fix issue 39: idf is 0 when a token is in exactly 50% of the documents.
danerlt May 24, 2024
afc9557
fix: calc_idf method
danerlt May 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion rank_bm25.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ def _calc_idf(self, nd):
# idf can be negative if word is contained in more than half of documents
negative_idfs = []
for word, freq in nd.items():
idf = math.log(self.corpus_size - freq + 0.5) - math.log(freq + 0.5)
idf = math.log(self.corpus_size + 1) - math.log(freq + 0.5)
self.idf[word] = idf
idf_sum += idf
if idf < 0:
Expand Down
⚡