`buildenv` block uses `setenv` and does not recognise `PATH`-like variables

[ocaisa]

This means that it blows away important environment variables like CPLUS_INCLUDE_PATH

easybuild-easyblocks/easybuild/easyblocks/generic/buildenv.py

Lines 95 to 98 in 7e8ed9a

	# include environment variables defined for (non-system) toolchain
	if not self.toolchain.is_system_toolchain():
	for key, val in sorted(self.toolchain.vars.items()):
	txt += self.module_generator.set_environment(key, val)

[ocaisa]

To use pushenv, the values need to be dicts: {'value': val, 'pushenv': True}

[ocaisa]

For the cases that I see CPATH, CPLUS_INCLUDE_PATH, OBJC_INCLUDE_PATH, C_INCLUDE_PATH just matching to *PATH could be a reasonable heuristic

[ocaisa]

For paths I think I can just use:

https://github.com/easybuilders/easybuild-framework/blob/2885cad5b361f4590a4a83668ea92f5f35c634ec/easybuild/tools/toolchain/constants.py#L70-L76

and include LD_LIBRARYPATH (only including them if they are actually set)

[ocaisa]

Perhaps the easyblock should make it optional if these are set at all? Maybe at the compiler level (buildenv for GCC for example), we don't set them and only trigger the wrappers?

[ocaisa]

Probably should have different switches for each of the cases in https://github.com/easybuilders/easybuild-framework/blob/2885cad5b361f4590a4a83668ea92f5f35c634ec/easybuild/tools/toolchain/constants.py#L39-L77