Be more careful with `PATH`-like environment variables when using `buildenv` + use `pushenv` for other environment variables by ocaisa · Pull Request #4007 · easybuilders/easybuild-easyblocks

ocaisa · 2025-12-04T09:24:28Z

And also always use pushenv for everything else so users can recover environment variables they may set independently.

Fixes #4004

ocaisa · 2025-12-04T09:28:00Z

@boegelbot please test @ jsc-zen3
EB_ARGS="buildenv-default-foss-2023a.eb"

boegelbot · 2025-12-04T09:33:10Z

@ocaisa: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=4007 EB_ARGS="buildenv-default-foss-2023a.eb" EB_CONTAINER= EB_REPO=easybuild-easyblocks EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_4007 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

exit code: 0
output:

Submitted batch job 9000

Test results coming soon (I hope)...

Details

- notification for comment with ID 3611079310 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

boegelbot · 2025-12-04T09:33:42Z

Test report by @boegelbot

Overview of tested easyconfigs (in order)

SUCCESS buildenv-default-foss-2023a.eb

Build succeeded for 1 out of 1 (total: 18 secs) (1 easyconfigs in total)
jsczen3c1.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.6, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.21
See https://gist.github.com/boegelbot/5d1868cdfa8d994096925b7e22f2a29e for a full test report.

ocaisa · 2025-12-04T09:33:51Z

+            path_like_vars = {key for key, _ in COMPILER_MAP_CLASS[SearchPaths]}
+            path_like_vars.add('LIBRARY_PATH')
+            path_like_vars.add('LD_LIBRARY_PATH')
+            for key, val in sorted(self.toolchain.vars.items()):


For the easybuild configuration of EESSI/2025.06 I noted that header libraries are always set in these items (C_INCLUDE_PATH etc.). Since the easyblock used setenv(), the existing paths were being wiped away. This fixes that specific problem in a general way.

In EESSI/2023.06 this does not seem to be a problem as CPATH was not being set. Regardless, all angles are covered now and it is also more flexible by the use of pushenv() in general.

ocaisa · 2025-12-04T09:39:03Z

diff new_module.txt old_module.txt 
28a29
> prepend_path("PATH","/home/ocaisa/eessi/versions/2025.06/software/linux/x86_64/intel/icelake/software/buildenv/default-GCC-13.3.0/bin/rpath_wrappers/rpath_args.py")
33,47c34,51
< pushenv("CC","gcc")
< pushenv("CFLAGS","-O2 -ftree-vectorize -march=native -fno-math-errno")
< pushenv("CXX","g++")
< pushenv("CXXFLAGS","-O2 -ftree-vectorize -march=native -fno-math-errno")
< pushenv("F77","gfortran")
< pushenv("F90","gfortran")
< pushenv("F90FLAGS","-O2 -ftree-vectorize -march=native -fno-math-errno")
< pushenv("FC","gfortran")
< pushenv("FCFLAGS","-O2 -ftree-vectorize -march=native -fno-math-errno")
< pushenv("FFLAGS","-O2 -ftree-vectorize -march=native -fno-math-errno")
< pushenv("FLIBS","-lgfortran")
< pushenv("LDFLAGS","-L/cvmfs/software.eessi.io/versions/2025.06/software/linux/x86_64/intel/icelake/software/GCCcore/13.3.0/lib64 -L/cvmfs/software.eessi.io/versions/2025.06/software/linux/x86_64/intel/icelake/software/GCCcore/13.3.0/lib")
< pushenv("LIBS","-lm -lpthread")
< pushenv("OPTFLAGS","-O2 -ftree-vectorize -march=native")
< pushenv("PRECFLAGS","-fno-math-errno")
---
> setenv("CC","gcc")
> setenv("CFLAGS","-O2 -ftree-vectorize -march=native -fno-math-errno")
> setenv("CPLUS_INCLUDE_PATH","")
> setenv("CXX","g++")
> setenv("CXXFLAGS","-O2 -ftree-vectorize -march=native -fno-math-errno")
> setenv("C_INCLUDE_PATH","")
> setenv("F77","gfortran")
> setenv("F90","gfortran")
> setenv("F90FLAGS","-O2 -ftree-vectorize -march=native -fno-math-errno")
> setenv("FC","gfortran")
> setenv("FCFLAGS","-O2 -ftree-vectorize -march=native -fno-math-errno")
> setenv("FFLAGS","-O2 -ftree-vectorize -march=native -fno-math-errno")
> setenv("FLIBS","-lgfortran")
> setenv("LDFLAGS","-L/cvmfs/software.eessi.io/versions/2025.06/software/linux/x86_64/intel/icelake/software/GCCcore/13.3.0/lib64 -L/cvmfs/software.eessi.io/versions/2025.06/software/linux/x86_64/intel/icelake/software/GCCcore/13.3.0/lib")
> setenv("LIBS","-lm -lpthread")
> setenv("OBJC_INCLUDE_PATH","")
> setenv("OPTFLAGS","-O2 -ftree-vectorize -march=native")
> setenv("PRECFLAGS","-fno-math-errno")

ocaisa · 2025-12-04T10:27:38Z

@boegelbot please test @ jsc-zen3
EB_ARGS="buildenv-default-foss-2023a.eb"

boegelbot · 2025-12-04T10:33:09Z

@ocaisa: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=4007 EB_ARGS="buildenv-default-foss-2023a.eb" EB_CONTAINER= EB_REPO=easybuild-easyblocks EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_4007 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

exit code: 0
output:

Submitted batch job 9001

Test results coming soon (I hope)...

Details

- notification for comment with ID 3611371502 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

boegelbot · 2025-12-04T10:33:39Z

Test report by @boegelbot

Overview of tested easyconfigs (in order)

SUCCESS buildenv-default-foss-2023a.eb

Build succeeded for 1 out of 1 (total: 15 secs) (1 easyconfigs in total)
jsczen3c1.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.6, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.21
See https://gist.github.com/boegelbot/bdd9b5e264d797c4510c36bcee29e269 for a full test report.

…ame 'build_envvars' to 'build_env_vars'

boegel · 2025-12-09T08:17:01Z

@boegelbot please test @ jsc-zen3
EB_ARGS="buildenv-default-foss-2025a-CUDA-12.8.0.eb buildenv-default-intel-2025b.eb"

boegelbot · 2025-12-09T08:33:10Z

@boegel: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=4007 EB_ARGS="buildenv-default-foss-2025a-CUDA-12.8.0.eb buildenv-default-intel-2025b.eb" EB_CONTAINER= EB_REPO=easybuild-easyblocks EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_4007 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

exit code: 0
output:

Submitted batch job 9056

Test results coming soon (I hope)...

Details

- notification for comment with ID 3630933025 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

boegelbot · 2025-12-09T08:34:16Z

Test report by @boegelbot

Overview of tested easyconfigs (in order)

SUCCESS buildenv-default-foss-2025a-CUDA-12.8.0.eb
SUCCESS buildenv-default-intel-2025b.eb

Build succeeded for 2 out of 2 (total: 51 secs) (2 easyconfigs in total)
jsczen3c2.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.6, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.21
See https://gist.github.com/boegelbot/c792678220bbdaf8953bd6ebd72e20f0 for a full test report.

boegel

lgtm

ocaisa added 2 commits December 4, 2025 10:22

Be careful with PATH-like variables when using buildenv

36aab5a

Update buildenv.py

8120be5

ocaisa commented Dec 4, 2025

View reviewed changes

Update buildenv.py

2c6a170

boegel added bug fix EESSI Related to EESSI project labels Dec 9, 2025

boegel added this to the next release (5.2.0) milestone Dec 9, 2025

boegel requested changes Dec 9, 2025

View reviewed changes

Comment thread easybuild/easyblocks/generic/buildenv.py Outdated

Comment thread easybuild/easyblocks/generic/buildenv.py Outdated

boegel added 2 commits December 9, 2025 09:12

sort custom easyconfig parameters in buildenv easyblock alphabetically

5e2dca9

initialise pushenv_env_vars in constructor of buildenv easyblock, ren…

3a2f803

…ame 'build_envvars' to 'build_env_vars'

boegel force-pushed the fix_buildenv branch from c22a556 to 3a2f803 Compare December 9, 2025 08:16

boegel changed the title ~~Be careful with PATH-like variables when using buildenv~~ Be more careful with PATH-like environment variables when using buildenv + use pushenv for other environment variables Dec 9, 2025

boegel approved these changes Dec 9, 2025

View reviewed changes

boegel merged commit 47f37c6 into easybuilders:develop Dec 9, 2025
22 checks passed

Conversation

ocaisa commented Dec 4, 2025

Uh oh!

ocaisa commented Dec 4, 2025

Uh oh!

boegelbot commented Dec 4, 2025

Uh oh!

boegelbot commented Dec 4, 2025

Overview of tested easyconfigs (in order)

Uh oh!

ocaisa Dec 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ocaisa commented Dec 4, 2025

Uh oh!

ocaisa commented Dec 4, 2025

Uh oh!

boegelbot commented Dec 4, 2025

Uh oh!

boegelbot commented Dec 4, 2025

Overview of tested easyconfigs (in order)

Uh oh!

Uh oh!

Uh oh!

boegel commented Dec 9, 2025

Uh oh!

boegelbot commented Dec 9, 2025

Uh oh!

boegelbot commented Dec 9, 2025

Overview of tested easyconfigs (in order)

Uh oh!

boegel left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

ocaisa Dec 4, 2025 •

edited

Loading