Update optional feature support of TensorFlow#2314
Update optional feature support of TensorFlow#2314boegel merged 2 commits intoeasybuilders:developfrom
Conversation
58160bc to
474173f
Compare
474173f to
b3e5609
Compare
|
Rebased and dependencies removed. No changes and this was already tested with easybuilders/easybuild-easyconfigs#12037, so should be good to go |
Since the impact of defining We should only use |
Co-authored-by: Kenneth Hoste <kenneth.hoste@ugent.be>
|
Test report by @boegel Overview of tested easyconfigs (in order)
Build succeeded for 2 out of 2 (2 easyconfigs in total) |
|
Test report by @boegel Overview of tested easyconfigs (in order)
Build succeeded for 2 out of 2 (2 easyconfigs in total) |
(created using
eb --new-pr)We used
TF_NEED_*env variables to enable/disable features but those became out of sync with TF moving to--configoptions. This adds a check for all setTF_*variables that they are (still) relevant, i.e. contained inconfigure.pyand prints a warning (@boegel IMOprint_warningmakes more sense here as a failure likely results in misconfiguration of TF, but you were more sparing with the before, so what shall it be?)I also checked all variables through
git bisectto find when they were introduced or removed and adapted the code to only use the valid ones.There may be functional changes because
--config=no*options were missing before but I'd consider those as a bugfix, not a change becauseTF_NEED_*=0was used for those.