Skip to content

enhance extract_cmd function to use 'cp -a' for shell scripts (.sh)#3545

Merged
ocaisa merged 2 commits intoeasybuilders:developfrom
boegel:extract_cmd_sh
Jan 11, 2021
Merged

enhance extract_cmd function to use 'cp -a' for shell scripts (.sh)#3545
ocaisa merged 2 commits intoeasybuilders:developfrom
boegel:extract_cmd_sh

Conversation

@boegel
Copy link
Copy Markdown
Member

@boegel boegel commented Jan 10, 2021

This fixes the following issue when trying to install something that only involves a shell script as "source" file:

 Unknown file type for file l_HPCKit_p_2021.1.0.2684_offline.sh

(triggered with easybuilders/easybuild-easyconfigs#11982)

@boegel boegel added this to the next release (4.3.3?) milestone Jan 10, 2021
Copy link
Copy Markdown
Member

@ocaisa ocaisa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM apart from comment

Comment thread easybuild/tools/filetools.py Outdated
Co-authored-by: ocaisa <a.ocais@fz-juelich.de>
Comment thread test/framework/filetools.py
Copy link
Copy Markdown
Member

@ocaisa ocaisa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ocaisa ocaisa merged commit 3536ac7 into easybuilders:develop Jan 11, 2021
@boegel boegel changed the title enhance extract_cmd functio to use 'cp -a' for shell scripts (.sh) enhance extract_cmd function to use 'cp -a' for shell scripts (.sh) Jan 11, 2021
@boegel boegel deleted the extract_cmd_sh branch January 11, 2021 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants