feat: implemented update logic for deliveries#1004
Merged
tom-rm-meyer-ISST merged 4 commits intoeclipse-tractusx:feat/edit-modalsfrom Oct 9, 2025
Merged
feat: implemented update logic for deliveries#1004tom-rm-meyer-ISST merged 4 commits intoeclipse-tractusx:feat/edit-modalsfrom
tom-rm-meyer-ISST merged 4 commits intoeclipse-tractusx:feat/edit-modalsfrom
Conversation
tom-rm-meyer-ISST
requested changes
Oct 8, 2025
Contributor
tom-rm-meyer-ISST
left a comment
tom-rm-meyer-ISST
left a comment
There was a problem hiding this comment.
Thanks, great contribution and will support the incorporation of the feature!
I did some freehand testing to ensure validations are fine and found a few issues (also in my "specification").
Further, I've forgot to mention that we please raise the pr against this branch so that we merge it as a bundle of features: feat/edit-modals
ReneSchroederLJ
force-pushed
the
feat/delivery-update
branch
from
aa9df19 to
2a13eff
Compare
3 tasks
tom-rm-meyer-ISST
requested changes
Oct 9, 2025
Contributor
tom-rm-meyer-ISST
left a comment
tom-rm-meyer-ISST
left a comment
There was a problem hiding this comment.
Thanks for iterating over it with me!
Found one further valdiation not working and smaller question.
tom-rm-meyer-ISST
approved these changes
Oct 9, 2025
Contributor
tom-rm-meyer-ISST
left a comment
tom-rm-meyer-ISST
left a comment
There was a problem hiding this comment.
LGTM, thanks a lot. I noticed that we didn't update the user guide. Maybe it makes sense to do it in the end for all modals before merging the branch. I raised issue #1017
tom-rm-meyer-ISST
merged commit 4773c47
into
eclipse-tractusx:feat/edit-modals
11 checks passed
8 tasks
tom-rm-meyer-ISST
added a commit
that referenced
this pull request
Jan 7, 2026
* feat: implemented update logic for deliveries (#1004) * feat: implemented update logic for deliveries * fix: bug in validation logic * fix: improved feedback for invalid inputs * fix: arrival-type validations * feat(material details view): add edit functionality for stock modals (#1026) * Implemented Edit functionality for Stock dialog * updated entry in changelog * 1022 PR (Edit stock Modal) changes * Removed mode from dataModal for Stock * resolved quantity update issue for stock modal * resolved update quantity stock issue * feat: added edit functionality for demand dialog (#1028) * Added Edit functionality for Demand modal * Added entry for demand modal * Demand modal Date patched changes * Implemented edit functionality for Stock modal * resolved quantity update issue for demand modal * Revert "Implemented edit functionality for Stock modal" This reverts commit 53b4b44. * Revert "feat(material-details view): added material no. (#1005)" This reverts commit 13a5488. * PR #1028 review changes * Fixed date patch issue * Hide edit for reported demand * feat: add edit functionality for production modal (#1037) * Implemented edit functionality for Production modal * Added entry for production modal in changelog * Typo correction * Made PR1037 review changes * Hide edid for reported productions * chore: fix merge faults * fix: don't allow editation for reported stocks * docs(user guide): added update modal features (#1070) * chore: correct IAV company name in license header --------- Co-authored-by: René Schröder <131770181+ReneSchroederLJ@users.noreply.github.com> Co-authored-by: Akash-IAV <extern.akash.pandit@iav.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
resolves #1007
Pre-review checks
Please ensure to do as many of the following checks as possible, before asking for committer review: