Skip to content

Added material no. in material detail view(982)#1005

Merged
tom-rm-meyer-ISST merged 5 commits intoeclipse-tractusx:mainfrom
Akash-IAV:P1_Improvements_and_fixes
Oct 14, 2025
Merged

Added material no. in material detail view(982)#1005
tom-rm-meyer-ISST merged 5 commits intoeclipse-tractusx:mainfrom
Akash-IAV:P1_Improvements_and_fixes

Conversation

@Akash-IAV
Copy link
Copy Markdown
Contributor

@Akash-IAV Akash-IAV commented Oct 7, 2025 •
edited
Loading

Description

Pre-review checks

Please ensure to do as many of the following checks as possible, before asking for committer review:

  • DEPENDENCIES are up-to-date. Dash license tool. Committers can open IP issues for restricted libs.
  • Copyright and license header are present on all affected files
  • If helm chart has been changed, the chart version has been bumped to either next major, minor or patch level (compared to released chart).

@tom-rm-meyer-ISST tom-rm-meyer-ISST mentioned this pull request Oct 9, 2025
Closed
3 tasks
tom-rm-meyer-ISST
tom-rm-meyer-ISST requested changes Oct 9, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@tom-rm-meyer-ISST tom-rm-meyer-ISST left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!

Please separate the PR from #1006. Further incorporate the overall guidance from this comment.

Comment thread frontend/src/features/material-details/components/MaterialDetailsHeader.tsx Outdated
tom-rm-meyer-ISST
tom-rm-meyer-ISST requested changes Oct 13, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@tom-rm-meyer-ISST tom-rm-meyer-ISST left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for separating the changes. Please check the comments.

Please also rerequest review whenever you want me to review again. Comments I sometimes miss.

Comment thread frontend/src/features/material-details/components/StockModal.tsx
Comment thread CHANGELOG.md Outdated
Comment thread CHANGELOG.md
Copy link
Copy Markdown
Contributor

@tom-rm-meyer-ISST tom-rm-meyer-ISST Oct 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Main has verison 4.0.1. Version 4.0.0 has already been released. If you rebase to / merge main, the version bump would be correct. The changelog entry should be added for 4.0.1.

That way also no change to pom, package, chart, etc isn't needed because it has already been done.

Copy link
Copy Markdown
Contributor Author

@Akash-IAV Akash-IAV Oct 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I changed to 4.0.1 now, Please check

Copy link
Copy Markdown
Contributor

@tom-rm-meyer-ISST tom-rm-meyer-ISST Oct 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe a misunderstanding. The current state has been outdated referring to main and thus a merge has been needed (that was what I meant with "main has version 4.0.1). This involves also updating the version number in different files. I merged it for convenience! :)

tom-rm-meyer-ISST
tom-rm-meyer-ISST approved these changes Oct 14, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@tom-rm-meyer-ISST tom-rm-meyer-ISST left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, as stated in comment: please always make sure to be in sync with the target branch to ensure that the changelog + all release related artifacts are up to date.

Comment thread CHANGELOG.md
Copy link
Copy Markdown
Contributor

@tom-rm-meyer-ISST tom-rm-meyer-ISST Oct 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe a misunderstanding. The current state has been outdated referring to main and thus a merge has been needed (that was what I meant with "main has version 4.0.1). This involves also updating the version number in different files. I merged it for convenience! :)

@tom-rm-meyer-ISST tom-rm-meyer-ISST linked an issue Oct 14, 2025 that may be closed by this pull request
[Story] Add the material number in material details view in the top next to the name #982
Closed
@tom-rm-meyer-ISST tom-rm-meyer-ISST merged commit 13a5488 into eclipse-tractusx:main Oct 14, 2025
13 checks passed
Akash-IAV added a commit to Akash-IAV/puris that referenced this pull request Oct 27, 2025
@Akash-IAV
Revert "feat(material-details view): added material no. (eclipse-trac…
1b7b023 
…tusx#1005)"

This reverts commit 13a5488.
tom-rm-meyer-ISST pushed a commit that referenced this pull request Jan 6, 2026
@Akash-IAV
feat: added edit functionality for demand dialog (#1028)
dc70b36 
* Added Edit functionality for Demand modal

* Added entry for demand modal

* Demand modal Date patched changes

* Implemented edit functionality for Stock modal

* resolved quantity update issue for demand modal

* Revert "Implemented edit functionality for Stock modal"

This reverts commit 53b4b44.

* Revert "feat(material-details view): added material no. (#1005)"

This reverts commit 13a5488.

* PR #1028 review changes

* Fixed date patch issue

* Hide edit for reported demand
tom-rm-meyer-ISST added a commit that referenced this pull request Jan 7, 2026
@tom-rm-meyer-ISST @ReneSchroederLJ @Akash-IAV
feat: add edit modals for operational data (#1069)
7c39723 
* feat: implemented update logic for deliveries (#1004)

* feat: implemented update logic for deliveries

* fix: bug in validation logic

* fix: improved feedback for invalid inputs

* fix: arrival-type validations

* feat(material details view): add edit functionality for stock modals (#1026)

* Implemented Edit functionality for Stock dialog

* updated entry in changelog

* 1022 PR (Edit stock Modal)  changes

* Removed mode from dataModal for Stock

* resolved quantity update issue for stock modal

* resolved update quantity stock issue

* feat: added edit functionality for demand dialog (#1028)

* Added Edit functionality for Demand modal

* Added entry for demand modal

* Demand modal Date patched changes

* Implemented edit functionality for Stock modal

* resolved quantity update issue for demand modal

* Revert "Implemented edit functionality for Stock modal"

This reverts commit 53b4b44.

* Revert "feat(material-details view): added material no. (#1005)"

This reverts commit 13a5488.

* PR #1028 review changes

* Fixed date patch issue

* Hide edit for reported demand

* feat: add edit functionality for production modal (#1037)

* Implemented edit functionality for Production modal

* Added entry for production modal in changelog

* Typo correction

* Made PR1037 review changes

* Hide edid for reported productions

* chore: fix merge faults

* fix: don't allow editation for reported stocks

* docs(user guide): added update modal features (#1070)

* chore: correct IAV company name in license header

---------

Co-authored-by: René Schröder <131770181+ReneSchroederLJ@users.noreply.github.com>
Co-authored-by: Akash-IAV <extern.akash.pandit@iav.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tom-rm-meyer-ISST tom-rm-meyer-ISST tom-rm-meyer-ISST approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Story] Add the material number in material details view in the top next to the name

2 participants

@Akash-IAV @tom-rm-meyer-ISST
⚡