refactor(local deployment): parametrize partners#1073
refactor(local deployment): parametrize partners#1073tom-rm-meyer-ISST merged 6 commits intomainfrom
Conversation
ReneSchroederLJ
left a comment
There was a problem hiding this comment.
Great work thank you for the contribution. Makes it much easier to change key parameters.
One thing I noticed is that while we use the environment in most instances there are some places where we still use hardcoded values. One example are the constants for the wallet mock.
Do you think we should address this to make sure that changing the BPNLs in the generate-keys script does not have unwanted side effects?
Since the mock is not the default anymore I would not see this as a reason to block the PR, but it's worth considering.
I incorporated the change for the |
Makes sense to me. Thank you for checking. |
ReneSchroederLJ
left a comment
There was a problem hiding this comment.
LGTM thank you for the effort.
Description
Currently we got the bpn in the
generate-keys.shhardcoded. This pr puts them as changeable parameter into the beginnning. This allows us to easier create an INT environment.Further:
Pre-review checks
Please ensure to do as many of the following checks as possible, before asking for committer review:
changelog.md) with PR reference and brief summary.frontend/package.json,frontend/package-lock.json)backend/pom.xml)scripts/generate_openapi_yaml.pywith running customer backend)