Skip to content

refactor(local deployment): parametrize partners#1073

Merged
tom-rm-meyer-ISST merged 6 commits intomainfrom
refactor/parametrize-partners
Feb 9, 2026
Merged

refactor(local deployment): parametrize partners#1073
tom-rm-meyer-ISST merged 6 commits intomainfrom
refactor/parametrize-partners

Conversation

@tom-rm-meyer-ISST
Copy link
Copy Markdown
Contributor

@tom-rm-meyer-ISST tom-rm-meyer-ISST commented Jan 29, 2026

Description

Currently we got the bpn in the generate-keys.sh hardcoded. This pr puts them as changeable parameter into the beginnning. This allows us to easier create an INT environment.

Further:

  • fixes wrong keycloak port so that the integration tests don't fail anymore (introduced accidentally in #1066)
  • added missing version bump in openApi

Pre-review checks

Please ensure to do as many of the following checks as possible, before asking for committer review:

  • DEPENDENCIES are up-to-date. Dash license tool. Committers can open IP issues for restricted libs.
  • Copyright and license header are present on all affected files (TRG 7.02
  • Documentation Notice are present on all affected files (TRG 7.07)
  • If helm chart has been changed, the chart version has been bumped to either next major, minor or patch level (compared to released chart).
  • Changelog updated (changelog.md) with PR reference and brief summary.
  • Frontend version bumped, if needed (frontend/package.json, frontend/package-lock.json)
  • Backend version bumped, if needed (backend/pom.xml)
  • Open API specification updated, if controllers have been changed (use python script scripts/generate_openapi_yaml.py with running customer backend)

@tom-rm-meyer-ISST tom-rm-meyer-ISST marked this pull request as ready for review January 29, 2026 14:22
@tom-rm-meyer-ISST tom-rm-meyer-ISST linked an issue Feb 2, 2026 that may be closed by this pull request
Copy link
Copy Markdown
Member

@ReneSchroederLJ ReneSchroederLJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work thank you for the contribution. Makes it much easier to change key parameters.

One thing I noticed is that while we use the environment in most instances there are some places where we still use hardcoded values. One example are the constants for the wallet mock.

Do you think we should address this to make sure that changing the BPNLs in the generate-keys script does not have unwanted side effects?

Since the mock is not the default anymore I would not see this as a reason to block the PR, but it's worth considering.

@tom-rm-meyer-ISST
Copy link
Copy Markdown
Contributor Author

tom-rm-meyer-ISST commented Feb 9, 2026

Great work thank you for the contribution. Makes it much easier to change key parameters.

One thing I noticed is that while we use the environment in most instances there are some places where we still use hardcoded values. One example are the constants for the wallet mock.

Do you think we should address this to make sure that changing the BPNLs in the generate-keys script does not have unwanted side effects?

Since the mock is not the default anymore I would not see this as a reason to block the PR, but it's worth considering.

I incorporated the change for the ssi-dim-walllet-stub and would not do it for the mock as this is quite hard. I checked whether it's working by changing customer and supplier bpnl (not part of the commit)

@ReneSchroederLJ
Copy link
Copy Markdown
Member

I incorporated the change for the ssi-dim-walllet-stub and would not do it for the mock as this is quite hard. I checked whether it's working by changing customer and supplier bpnl (not part of the commit)

Makes sense to me. Thank you for checking.

Copy link
Copy Markdown
Member

@ReneSchroederLJ ReneSchroederLJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thank you for the effort.

@tom-rm-meyer-ISST tom-rm-meyer-ISST merged commit c2e0157 into main Feb 9, 2026
13 checks passed
@tom-rm-meyer-ISST tom-rm-meyer-ISST deleted the refactor/parametrize-partners branch February 9, 2026 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Bruno DTR requests failing due to invalid Keycloak url

3 participants