Skip to content

feat: add support for OAuth2 configuration in BaseConnectorProviderService.create_asset#176

Open
CDiezRodriguez wants to merge 6 commits intomainfrom
feat/enable-support-for-connector-assets-with-data-addresses-protected-by-oauth2
Open

feat: add support for OAuth2 configuration in BaseConnectorProviderService.create_asset#176
CDiezRodriguez wants to merge 6 commits intomainfrom
feat/enable-support-for-connector-assets-with-data-addresses-protected-by-oauth2

Conversation

@CDiezRodriguez
Copy link
Copy Markdown
Contributor

WHAT

Added support for OAuth2 authorization in asset data addresses within the create_asset method of BaseConnectorProviderService.

A new optional parameter oauth2_config has been added that accepts a dictionary with the following keys:

  • tokenUrl: URL to request the OAuth2 access token
  • clientId: The client ID for OAuth2 authentication
  • clientSecretKey: The key in the Vault where the client secret is stored

When provided, these values are added to the data address with the proper oauth2: prefix as expected by the connector.

WHY

The connector documentation states that HTTP Data Plane data addresses can be protected by OAuth2 authentication. However, the SDK's method did not support this configuration, limiting users from creating assets with OAuth2-protected backend data sources.

FURTHER NOTES

  • Added comprehensive docstring to the create_asset method documenting all parameters including the new oauth2_config
  • The implementation follows the connector's expected format for OAuth2 configuration (oauth2:tokenUrl, oauth2:clientId, oauth2:clientSecretKey)

Closes #175

@CDiezRodriguez CDiezRodriguez self-assigned this Dec 16, 2025
@github-actions
Copy link
Copy Markdown

github-actions bot commented Dec 16, 2025

🧪 Test Summary

🎉 Status: SUCCESS

📊 Unit Tests

Passed Failed Total Coverage
✅ 407 ❌ 0 📋 407 📈 68.08%
Run Details
  • Branch: 176/merge
  • Commit: 0dd39187c935c3d0d10f84807133652b04f8ebd2
  • Trigger: pull_request

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Dec 16, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@CDiezRodriguez CDiezRodriguez marked this pull request as draft February 9, 2026 08:14
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Feb 9, 2026

Quality Gate Failed Quality Gate failed

Failed conditions
4 Security Hotspots

See analysis details on SonarQube Cloud

@CDiezRodriguez CDiezRodriguez marked this pull request as ready for review February 9, 2026 13:00
Copy link
Copy Markdown
Contributor

@matbmoser matbmoser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is great PR, but lets include it in the next release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Enable Support for Connector Assets with Data Addresses Protected by OAuth2

2 participants