Skip to content

fix: java output location moved to src/main#3

Merged
eladb merged 4 commits intocdklabs:masterfrom
campionfellin:javaimports
Jun 16, 2020
Merged

fix: java output location moved to src/main#3
eladb merged 4 commits intocdklabs:masterfrom
campionfellin:javaimports

Conversation

@campionfellin
Copy link
Copy Markdown
Contributor

Signed-off-by: campionfellin campionfellin@gmail.com

Issue #, if available:

None, but related to comments on this PR:

cdk8s-team/cdk8s#233 (comment)

Description of changes:

Rather than putting imports into a deep folder structure with package name, they all fall under src/main. A cdk8s java project with multiple imports looks like:

imports/
  src/
    main/
      java/
        k8s/
        mattermost/
      resources/
        k8s/
        mattermost/

Note: using ncp because fs-extra doesn't have copy/merge functionality.

With fs.move option overwrite as true, you only get the last import in your list of imports. With overwrite false, it fails because imports/src/main/ already exists. We want to effectively merge the two imports into this folder. ncp seemed like the best option here for this.

Tested by yarn linking this with cdk8s and importing over there.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Signed-off-by: campionfellin <campionfellin@gmail.com>
Signed-off-by: campionfellin <campionfellin@gmail.com>
Signed-off-by: campionfellin <campionfellin@gmail.com>
Signed-off-by: campionfellin <campionfellin@gmail.com>
@eladb eladb changed the title fix: java import location moved to src/main/ fix: java output location moved to src/main Jun 16, 2020
@eladb eladb merged commit 96c76e4 into cdklabs:master Jun 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants