Skip to content

Fix invite test flake #29753

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Half-Shot merged 6 commits into from
Apr 15, 2025
Merged

Fix invite test flake #29753

Changes from 4 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
e53485d
Mask mxid from screenshot
Half-Shot Apr 15, 2025
5daa9c8
s/hot/not/
Half-Shot Apr 15, 2025
d6bbaad
Hide the mxid entirely
Half-Shot Apr 15, 2025
cafb5e9
Merge branch 'develop' into hs/fix-invite-flake
Half-Shot Apr 15, 2025
f0a8f96
Add new snapshot
Half-Shot Apr 15, 2025
88a4e4b
Merge branch 'develop' into hs/fix-invite-flake
Half-Shot Apr 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion playwright/e2e/room/invites.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,14 @@
const roomId = await bot.createRoom({ is_direct: true });
await bot.inviteUser(roomId, user.userId);
await app.viewRoomByName("Bob");
await expect(page.locator(".mx_RoomView")).toMatchScreenshot("Invites_room_view.png");
await expect(page.locator(".mx_RoomView")).toMatchScreenshot("Invites_room_view.png", {

Check failure on line 22 in playwright/e2e/room/invites.spec.ts

View workflow job for this annotation

GitHub Actions / Run Tests [Chrome] 4/6

[Chrome] › playwright/e2e/room/invites.spec.ts:18:9 › Invites › should render an invite view @screenshot 

  1) [Chrome] › playwright/e2e/room/invites.spec.ts:18:9 › Invites › should render an invite view @screenshot 
    Error: expect(locator).toHaveScreenshot(expected)

      9977 pixels (ratio 0.02 of all image pixels) are different.

    Expected: /home/runner/work/element-web/element-web/playwright/snapshots/room/invites.spec.ts/Invites-room-view-linux.png
    Received: /home/runner/work/element-web/element-web/playwright/test-results/room-invites-Invites-should-render-an-invite-view-Chrome/Invites-room-view-actual.png
        Diff: /home/runner/work/element-web/element-web/playwright/test-results/room-invites-Invites-should-render-an-invite-view-Chrome/Invites-room-view-diff.png

    Call log:
      - expect.toHaveScreenshot(Invites-room-view.png) with timeout 5000ms
        - verifying given screenshot expectation
      - waiting for locator('.mx_RoomView')
        - locator resolved to <div class="mx_RoomView">…</div>
      - taking element screenshot
        - disabled all CSS animations
      - waiting for fonts to load...
      - fonts loaded
      - attempting scroll into view action
        - waiting for element to be stable
      - 9977 pixels (ratio 0.02 of all image pixels) are different.
      - waiting 100ms before taking screenshot
      - waiting for locator('.mx_RoomView')
        - locator resolved to <div class="mx_RoomView">…</div>
      - taking element screenshot
        - disabled all CSS animations
      - waiting for fonts to load...
      - fonts loaded
      - attempting scroll into view action
        - waiting for element to be stable
      - captured a stable screenshot
      - 9977 pixels (ratio 0.02 of all image pixels) are different.


      20 |         await bot.inviteUser(roomId, user.userId);
      21 |         await app.viewRoomByName("Bob");
    > 22 |         await expect(page.locator(".mx_RoomView")).toMatchScreenshot("Invites_room_view.png", {
         |                                                    ^
      23 |             // Hide the mxid, which is not stable.
      24 |             css: `
      25 |                 .mx_RoomPreviewBar_inviter_mxid {
        at /home/runner/work/element-web/element-web/playwright/e2e/room/invites.spec.ts:22:52

Check failure on line 22 in playwright/e2e/room/invites.spec.ts

View workflow job for this annotation

GitHub Actions / Run Tests [Chrome] 4/6

[Chrome] › playwright/e2e/room/invites.spec.ts:18:9 › Invites › should render an invite view @screenshot 

  1) [Chrome] › playwright/e2e/room/invites.spec.ts:18:9 › Invites › should render an invite view @screenshot 

    Retry #1 ───────────────────────────────────────────────────────────────────────────────────────
    Error: expect(locator).toHaveScreenshot(expected)

      9977 pixels (ratio 0.02 of all image pixels) are different.

    Expected: /home/runner/work/element-web/element-web/playwright/snapshots/room/invites.spec.ts/Invites-room-view-linux.png
    Received: /home/runner/work/element-web/element-web/playwright/test-results/room-invites-Invites-should-render-an-invite-view-Chrome-retry1/Invites-room-view-actual.png
        Diff: /home/runner/work/element-web/element-web/playwright/test-results/room-invites-Invites-should-render-an-invite-view-Chrome-retry1/Invites-room-view-diff.png

    Call log:
      - expect.toHaveScreenshot(Invites-room-view.png) with timeout 5000ms
        - verifying given screenshot expectation
      - waiting for locator('.mx_RoomView')
        - locator resolved to <div class="mx_RoomView">…</div>
      - taking element screenshot
        - disabled all CSS animations
      - waiting for fonts to load...
      - fonts loaded
      - attempting scroll into view action
        - waiting for element to be stable
      - 9977 pixels (ratio 0.02 of all image pixels) are different.
      - waiting 100ms before taking screenshot
      - waiting for locator('.mx_RoomView')
        - locator resolved to <div class="mx_RoomView">…</div>
      - taking element screenshot
        - disabled all CSS animations
      - waiting for fonts to load...
      - fonts loaded
      - attempting scroll into view action
        - waiting for element to be stable
      - captured a stable screenshot
      - 9977 pixels (ratio 0.02 of all image pixels) are different.


      20 |         await bot.inviteUser(roomId, user.userId);
      21 |         await app.viewRoomByName("Bob");
    > 22 |         await expect(page.locator(".mx_RoomView")).toMatchScreenshot("Invites_room_view.png", {
         |                                                    ^
      23 |             // Hide the mxid, which is not stable.
      24 |             css: `
      25 |                 .mx_RoomPreviewBar_inviter_mxid {
        at /home/runner/work/element-web/element-web/playwright/e2e/room/invites.spec.ts:22:52

Check failure on line 22 in playwright/e2e/room/invites.spec.ts

View workflow job for this annotation

GitHub Actions / Run Tests [Chrome] 4/6

[Chrome] › playwright/e2e/room/invites.spec.ts:18:9 › Invites › should render an invite view @screenshot 

  1) [Chrome] › playwright/e2e/room/invites.spec.ts:18:9 › Invites › should render an invite view @screenshot 

    Retry #2 ───────────────────────────────────────────────────────────────────────────────────────
    Error: expect(locator).toHaveScreenshot(expected)

      9977 pixels (ratio 0.02 of all image pixels) are different.

    Expected: /home/runner/work/element-web/element-web/playwright/snapshots/room/invites.spec.ts/Invites-room-view-linux.png
    Received: /home/runner/work/element-web/element-web/playwright/test-results/room-invites-Invites-should-render-an-invite-view-Chrome-retry2/Invites-room-view-actual.png
        Diff: /home/runner/work/element-web/element-web/playwright/test-results/room-invites-Invites-should-render-an-invite-view-Chrome-retry2/Invites-room-view-diff.png

    Call log:
      - expect.toHaveScreenshot(Invites-room-view.png) with timeout 5000ms
        - verifying given screenshot expectation
      - waiting for locator('.mx_RoomView')
        - locator resolved to <div class="mx_RoomView">…</div>
      - taking element screenshot
        - disabled all CSS animations
      - waiting for fonts to load...
      - fonts loaded
      - attempting scroll into view action
        - waiting for element to be stable
      - 9977 pixels (ratio 0.02 of all image pixels) are different.
      - waiting 100ms before taking screenshot
      - waiting for locator('.mx_RoomView')
        - locator resolved to <div class="mx_RoomView">…</div>
      - taking element screenshot
        - disabled all CSS animations
      - waiting for fonts to load...
      - fonts loaded
      - attempting scroll into view action
        - waiting for element to be stable
      - captured a stable screenshot
      - 9977 pixels (ratio 0.02 of all image pixels) are different.


      20 |         await bot.inviteUser(roomId, user.userId);
      21 |         await app.viewRoomByName("Bob");
    > 22 |         await expect(page.locator(".mx_RoomView")).toMatchScreenshot("Invites_room_view.png", {
         |                                                    ^
      23 |             // Hide the mxid, which is not stable.
      24 |             css: `
      25 |                 .mx_RoomPreviewBar_inviter_mxid {
        at /home/runner/work/element-web/element-web/playwright/e2e/room/invites.spec.ts:22:52
// Hide the mxid, which is not stable.
css: `
.mx_RoomPreviewBar_inviter_mxid {
display: none !important;
}
`,
});
});

test("should be able to decline an invite", async ({ page, homeserver, user, bot, app }) => {
Expand Down
Loading
⚡