Conversation
t3chguy
reviewed
Apr 15, 2025
Co-authored-by: Michael Telatynski <7t3chguy@gmail.com>
t3chguy
reviewed
Apr 15, 2025
| await expect(page.locator(".mx_RoomView")).toMatchScreenshot("Invites_room_view.png"); | ||
| await expect(page.locator(".mx_RoomView")).toMatchScreenshot("Invites_room_view.png", { | ||
| // Hide the mxid, which is not stable. | ||
| mask: [page.locator(".mx_RoomPreviewBar_inviter_mxid")], |
Member
There was a problem hiding this comment.
A mask may change width if the length (not monospace font) changes, so not sure this will fix it. It should either be on a fixed size block element or you should use css
Member
Author
There was a problem hiding this comment.
bah, good point. Let's have a look at the tree..
Member
Author
There was a problem hiding this comment.
(The tree did not offer a good candidate for masking so it's css for you, mxid field)
t3chguy
approved these changes
Apr 15, 2025
2 tasks
acheong08
pushed a commit
to acheong08/element-web
that referenced
this pull request
Apr 30, 2025
* Mask mxid from screenshot * s/hot/not/ Co-authored-by: Michael Telatynski <7t3chguy@gmail.com> * Hide the mxid entirely * Add new snapshot --------- Co-authored-by: Michael Telatynski <7t3chguy@gmail.com>
snowping
pushed a commit
to Novaloop-AG/element-web
that referenced
this pull request
Jun 22, 2025
* Mask mxid from screenshot * s/hot/not/ Co-authored-by: Michael Telatynski <7t3chguy@gmail.com> * Hide the mxid entirely * Add new snapshot --------- Co-authored-by: Michael Telatynski <7t3chguy@gmail.com>
Dileep9999
pushed a commit
to hemanth-nag/element-web
that referenced
this pull request
Oct 8, 2025
* Mask mxid from screenshot * s/hot/not/ Co-authored-by: Michael Telatynski <7t3chguy@gmail.com> * Hide the mxid entirely * Add new snapshot --------- Co-authored-by: Michael Telatynski <7t3chguy@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #29690
Checklist
public/exportedsymbols have accurate TSDoc documentation.