Skip to content

Fix another invite test flake#29812

Merged
Half-Shot merged 1 commit intodevelopfrom
hs/fix-invite-flake-again
Apr 25, 2025
Merged

Fix another invite test flake#29812
Half-Shot merged 1 commit intodevelopfrom
hs/fix-invite-flake-again

Conversation

@Half-Shot
Copy link
Copy Markdown
Member

@Half-Shot Half-Shot commented Apr 25, 2025

Fixes #29795

The UserID / Displayname could change on each test run causing flakes. Like #29753, I'm hiding the mxid from the screenshots and setting a constant displayname.

Checklist

  • Tests written for new code (and old code if feasible).
  • [N/A] New or updated public/exported symbols have accurate TSDoc documentation.
  • Linter and other CI checks pass.
  • [N/A] I have licensed the changes to Element by completing the Contributor License Agreement (CLA)

@Half-Shot Half-Shot added the T-Task Tasks for the team like planning label Apr 25, 2025
@Half-Shot Half-Shot requested a review from a team as a code owner April 25, 2025 09:04
@Half-Shot Half-Shot changed the title Fix another invite flake Fix another invite test flake Apr 25, 2025
Copy link
Copy Markdown
Member

@florianduros florianduros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Half-Shot Half-Shot added this pull request to the merge queue Apr 25, 2025
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Apr 25, 2025
@Half-Shot Half-Shot added this pull request to the merge queue Apr 25, 2025
Merged via the queue into develop with commit adc110a Apr 25, 2025
54 checks passed
@Half-Shot Half-Shot deleted the hs/fix-invite-flake-again branch April 25, 2025 13:24
acheong08 pushed a commit to acheong08/element-web that referenced this pull request Apr 30, 2025
snowping pushed a commit to Novaloop-AG/element-web that referenced this pull request Jun 22, 2025
Dileep9999 pushed a commit to hemanth-nag/element-web that referenced this pull request Oct 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

T-Task Tasks for the team like planning

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Flaky playwright test: timeline/media-preview-settings.spec.ts: should be able to hide avatars of inviters

2 participants