Update custom component logic to always return a hint.#30321
Closed
Update custom component logic to always return a hint.#30321
Conversation
t3chguy
reviewed
Jul 15, 2025
Member
t3chguy
left a comment
There was a problem hiding this comment.
I'm not sure if this is better, as it happens after a Promise which may cause a visual flicker where one can be avoided
5225819 to
09261c5
Compare
Member
Author
Yea, unsure. The intention is that by moving the defaults to the module layer, we don't need to replicate those defaults to every consumer of the hints. The alternative being I suppose that we change the type to be |
Member
Author
|
I don't think I'm progressing this for the moment. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successor to #30320
This changes the modules custom components API to always the expected hints, filling in with defaults where a renderer does not provide expected values.
Needs playwright tests.
Checklist
public/exportedsymbols have accurate TSDoc documentation.