Stabilize MImage/MVideoBodyView snapshots#33289
Queued
Conversation
t3chguy
reviewed
Apr 24, 2026
t3chguy
approved these changes
Apr 24, 2026
Any commits made after this event will not be merged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Importing a file via URL was causing the snapshots to end up with flaky hostnames on my system, unsure why but I suppose there is something special about my setup. Netherthless, we can do better here and use a more stable snapshot by using
importthat only includes the path to the file.Checklist
public/exportedsymbols have accurate TSDoc documentation.