Skip to content

Stabilize MImage/MVideoBodyView snapshots #33289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Half-Shot merged 4 commits into from
Apr 24, 2026
Merged

Stabilize MImage/MVideoBodyView snapshots #33289

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f4d2989
Stabilize MImage/MVideoBodyView snapshots
Half-Shot Apr 24, 2026
75fcb32
add to global
Half-Shot Apr 24, 2026
7d3bc1d
Use vite/client for imports
Half-Shot Apr 24, 2026
4661969
fixup
Half-Shot Apr 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions packages/shared-components/src/@types/global.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,3 @@ declare module "*.md?raw" {
const content: string;
export default content;
}

// For importing PNGs for use in testing
declare module "*.png" {
const content: string;
export default content;
}
7 changes: 3 additions & 4 deletions ...red-components/src/room/timeline/event-tile/body/MImageBodyView/ImageBodyView.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,10 +18,9 @@
type ImageBodyViewActions,
type ImageBodyViewSnapshot,
} from "./ImageBodyView";

const imageSrc = new URL("../../../../../../static/image-body/install-spinner.png", import.meta.url).href;
const thumbnailSrc = new URL("../../../../../../static/image-body/install-spinner.png", import.meta.url).href;
const animatedGifSrc = new URL("../../../../../../static/image-body/install-spinner.gif", import.meta.url).href;
import imageSrc from "../../../../../../static/image-body/install-spinner.png";

Check warning on line 21 in packages/shared-components/src/room/timeline/event-tile/body/MImageBodyView/ImageBodyView.stories.tsx

View check run for this annotation

SonarQubeCloud / SonarCloud Code Analysis

'/home/runner/work/element-web/element-web/packages/shared-components/static/image-body/install-spinner.png' imported multiple times. 


See more on https://sonarcloud.io/project/issues?id=element-web&issues=AZ2-fuUR1EVPJuqYy1wr&open=AZ2-fuUR1EVPJuqYy1wr&pullRequest=33289
import thumbnailSrc from "../../../../../../static/image-body/install-spinner.png";

Check warning on line 22 in packages/shared-components/src/room/timeline/event-tile/body/MImageBodyView/ImageBodyView.stories.tsx

View check run for this annotation

SonarQubeCloud / SonarCloud Code Analysis

'/home/runner/work/element-web/element-web/packages/shared-components/static/image-body/install-spinner.png' imported multiple times. 


See more on https://sonarcloud.io/project/issues?id=element-web&issues=AZ2-fuUR1EVPJuqYy1ws&open=AZ2-fuUR1EVPJuqYy1ws&pullRequest=33289
import animatedGifSrc from "../../../../../../static/image-body/install-spinner.gif";
const demoBlurhash = "LEHV6nWB2yk8pyo0adR*.7kCMdnj";
const imageBodyViewStateOptions = [ImageBodyViewState.ERROR, ImageBodyViewState.HIDDEN, ImageBodyViewState.READY];
const imageBodyViewPlaceholderOptions = [
Expand Down
16 changes: 8 additions & 8 deletions ...rc/room/timeline/event-tile/body/MImageBodyView/__snapshots__/ImageBodyView.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ exports[`ImageBodyView > matches snapshot for animated-preview story 1`] = `
>
<a
class="ImageBodyView-module_link"
href="http://localhost:63315/static/image-body/install-spinner.gif"
href="/static/image-body/install-spinner.gif"
>
<div
class="ImageBodyView-module_thumbnailContainer"
Expand All @@ -19,7 +19,7 @@ exports[`ImageBodyView > matches snapshot for animated-preview story 1`] = `
<img
alt="Element logo"
class="ImageBodyView-module_image"
src="http://localhost:63315/static/image-body/install-spinner.png"
src="/static/image-body/install-spinner.png"
/>
<p
class="ImageBodyView-module_gifLabel"
Expand All @@ -43,7 +43,7 @@ exports[`ImageBodyView > matches snapshot for default story 1`] = `
>
<a
class="ImageBodyView-module_link"
href="http://localhost:63315/static/image-body/install-spinner.png"
href="/static/image-body/install-spinner.png"
>
<div
class="ImageBodyView-module_thumbnailContainer"
Expand All @@ -55,7 +55,7 @@ exports[`ImageBodyView > matches snapshot for default story 1`] = `
<img
alt="Element logo"
class="ImageBodyView-module_image"
src="http://localhost:63315/static/image-body/install-spinner.png"
src="/static/image-body/install-spinner.png"
/>
</div>
</div>
Expand Down Expand Up @@ -147,7 +147,7 @@ exports[`ImageBodyView > matches snapshot for loading-with-blurhash story 1`] =
>
<a
class="ImageBodyView-module_link"
href="http://localhost:63315/static/image-body/install-spinner.png"
href="/static/image-body/install-spinner.png"
>
<div
class="ImageBodyView-module_thumbnailContainer"
Expand All @@ -173,7 +173,7 @@ exports[`ImageBodyView > matches snapshot for loading-with-blurhash story 1`] =
<img
alt="Element logo"
class="ImageBodyView-module_image"
src="http://localhost:63315/static/image-body/install-spinner.png"
src="/static/image-body/install-spinner.png"
/>
</div>
</div>
Expand All @@ -192,7 +192,7 @@ exports[`ImageBodyView > matches snapshot for loading-with-spinner story 1`] = `
>
<a
class="ImageBodyView-module_link"
href="http://localhost:63315/static/image-body/install-spinner.png"
href="/static/image-body/install-spinner.png"
>
<div
class="ImageBodyView-module_thumbnailContainer"
Expand Down Expand Up @@ -225,7 +225,7 @@ exports[`ImageBodyView > matches snapshot for loading-with-spinner story 1`] = `
<img
alt="Element logo"
class="ImageBodyView-module_image"
src="http://localhost:63315/static/image-body/install-spinner.png"
src="/static/image-body/install-spinner.png"
/>
</div>
</div>
Expand Down
3 changes: 1 addition & 2 deletions ...red-components/src/room/timeline/event-tile/body/MVideoBodyView/VideoBodyView.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,7 @@ import {
} from "./VideoBodyView";
import { useMockedViewModel } from "../../../../../core/viewmodel/useMockedViewModel";
import { withViewDocs } from "../../../../../../.storybook/withViewDocs";

const demoVideo = new URL("../../../../../../static/videoBodyDemo.webm", import.meta.url).href;
import demoVideo from "../../../../../../static/videoBodyDemo.webm";

type VideoBodyViewProps = VideoBodyViewSnapshot &
VideoBodyViewActions & {
Expand Down
2 changes: 1 addition & 1 deletion ...rc/room/timeline/event-tile/body/MVideoBodyView/__snapshots__/VideoBodyView.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ exports[`VideoBodyView > matches snapshot for ready story 1`] = `
crossorigin="anonymous"
poster="/static/element.png"
preload="none"
src="http://localhost:63315/static/videoBodyDemo.webm"
src="/static/videoBodyDemo.webm"
/>
</div>
<div>
Expand Down
8 changes: 4 additions & 4 deletions packages/shared-components/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,12 +14,12 @@
"declaration": true,
"jsx": "react",
"lib": ["es2022", "es2024.promise", "dom", "dom.iterable"],
"types": ["storybook-addon-vis/matcher"],
"types": ["vite/client", "storybook-addon-vis/matcher"],
"strict": true,
"paths": {
"@test-utils": ["./src/test/utils/index"]
}
"@test-utils": ["./src/test/utils/index"],
},
},
"include": ["./src/**/*.ts", "./src/**/*.tsx", ".storybook/*.ts", ".storybook/*.tsx"],
"references": [{ "path": "./tsconfig.node.json" }]
"references": [{ "path": "./tsconfig.node.json" }],
}
Loading
⚡