Clean up old device_federation_inbox rows#18546
Merged
erikjohnston merged 9 commits intodevelopfrom Jun 18, 2025
Merged
Conversation
erikjohnston
force-pushed
the
erikj/cleanup_federation_inbox
branch
from
15d3027 to
dcf32ac
Compare
erikjohnston
force-pushed
the
erikj/cleanup_federation_inbox
branch
from
dcf32ac to
83870d2
Compare
erikjohnston
force-pushed
the
erikj/cleanup_federation_inbox
branch
from
4b46247 to
03bd0bd
Compare
MatMaul
reviewed
Jun 13, 2025
Contributor
There was a problem hiding this comment.
it's... never deleted currently ?? 🫣 🫣
I think the corresponding issue would more be #17370.
I am trying to grasp the potential consequences of ingesting the to_device EDUs several times. From my understanding of the code the to_devices would be delivered several times to the devices.
Is it fine ? If not, going from forever to a week seems a bit of a gap. If it is, we could perhaps just deliver several times, since it is covering an edge case and shouldn't happen that often (request would have go through but not the response).
We could also ditch device_federation_inbox altogether and keep idempotency if we add message_id to device_inbox.
Member
Author
Ah indeed, that was the issue I meant to link to 🤦
I think that can happen anyway? Though would also be happy increasing the delay to a month or whatever, this table isn't particularly large.
Unfortunately we delete things from |
Contributor
Then perhaps ditching the table instead is better? better in the |
Member
Author
|
FTR I've checked internally with crypto team, and at least e2ee use cases will handle retransmission fine. |
MatMaul
approved these changes
Jun 16, 2025
Member
|
For future reference: That work should fall under a different issue if it's deemed worth the effort. |
devonh
reviewed
Jun 16, 2025
|
|
||
|
|
||
| # How long to keep messages in the device federation inbox before deleting them. | ||
| DEVICE_FEDERATION_INBOX_CLEANUP_DELAY_MS = 7 * 24 * 60 * 60 * 1000 # 7 days |
Contributor
There was a problem hiding this comment.
Probably worth building these up to avoid mistakes and make it more clear using the constants
synapse/synapse/util/constants.py
Lines 15 to 20 in f500c7d
We will need a few more:
ONE_MINUTE_SECONDS = 60
ONE_HOUR_SECONDS = 60 * ONE_MINUTE_SECONDS
ONE_DAY_SECONDS = 24 * ONE_HOUR_SECONDS
MILLISECONDS_PER_SECOND = 1000
Suggested change
| DEVICE_FEDERATION_INBOX_CLEANUP_DELAY_MS = 7 * 24 * 60 * 60 * 1000 # 7 days | |
| DEVICE_FEDERATION_INBOX_CLEANUP_DELAY_MS = 7 * ONE_DAY_SECONDS * MILLISECONDS_PER_SECOND |
Contributor
There was a problem hiding this comment.
It looks like a new Duration class was added.
Are we going to remove the other constants?
synapse/synapse/util/constants.py
Lines 15 to 20 in f500c7d
How are we going to handle the seconds variation (vs MS)?
Member
Author
There was a problem hiding this comment.
Are we going to remove the other constants?
Yes, we probably should, but didn't want to do it here
How are we going to handle the seconds variation (vs MS)?
Generally we rarely operate in seconds, except at twisted boundaries. TBH I think its fine in those cases to just / 1000.
devonh
approved these changes
Jun 17, 2025
Contributor
|
Hi, during my tests with 1.132.0 I found these errors logs, is this related? |
3 tasks
3 tasks
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #17370