Add missing await to sleep calls#18763
Merged
anoadragon453 merged 2 commits intodevelopfrom Aug 1, 2025
Merged
Conversation
reivilibre
approved these changes
Aug 1, 2025
Member
|
"oops" 😬 |
Member
Author
|
CI failures are a flaky test. Merging manually. |
| except LimitExceededError as e: | ||
| if e.pause: | ||
| self._clock.sleep(e.pause) | ||
| await self._clock.sleep(e.pause) |
Contributor
There was a problem hiding this comment.
Is this something we can lint?
We already detect this kind of thing for async/await
error: Value of type "Coroutine[Any, Any, None]" must be used [unused-coroutine]
note: Are you missing an await?
Member
There was a problem hiding this comment.
Oh mmm, we probably want to change the return type of sleep
erikjohnston
added a commit
that referenced
this pull request
Aug 4, 2025
This helps ensure that mypy can catch places where we don't await on it, like in #18763.
erikjohnston
added a commit
that referenced
this pull request
Aug 5, 2025
This helps ensure that mypy can catch places where we don't await on it, like in #18763. --------- Co-authored-by: Eric Eastwood <erice@element.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reported by @realtyem in DMs. The consequence was that logcontexts became lost for these code paths:
Missed in #18546 and #18595.
cc @erikjohnston
Pull Request Checklist
EventStoretoEventWorkerStore.".code blocks.