Skip to content

Prune sliding_sync_connection_required_state table#19306

Merged
erikjohnston merged 8 commits intodevelopfrom
erikj/delete_old_required_state
Jan 22, 2026
Merged

Prune sliding_sync_connection_required_state table#19306
erikjohnston merged 8 commits intodevelopfrom
erikj/delete_old_required_state

Conversation

@erikjohnston
Copy link
Copy Markdown
Member

When we change the required_state config for a room in sliding sync, we insert a new entry into the sliding_sync_connection_required_state table. As the sliding sync connection advances we can accrue a lot of stale entries, so let's clear those out.

This is a sort of follow on from #19211

@erikjohnston erikjohnston marked this pull request as ready for review December 15, 2025 14:02
@erikjohnston erikjohnston requested a review from a team as a code owner December 15, 2025 14:02
Comment thread synapse/storage/databases/main/sliding_sync.py Outdated
Comment thread synapse/storage/databases/main/sliding_sync.py
Comment thread tests/storage/test_sliding_sync_tables.py Outdated
Comment thread tests/storage/test_sliding_sync_tables.py
Comment thread synapse/storage/databases/main/sliding_sync.py Outdated
erikjohnston and others added 3 commits January 22, 2026 11:26
Co-authored-by: Eric Eastwood <erice@element.io>
Co-authored-by: Eric Eastwood <erice@element.io>
@erikjohnston erikjohnston enabled auto-merge (squash) January 22, 2026 11:53
@erikjohnston erikjohnston merged commit 064237a into develop Jan 22, 2026
78 of 80 checks passed
@erikjohnston erikjohnston deleted the erikj/delete_old_required_state branch January 22, 2026 12:37
alexlebens pushed a commit to alexlebens/infrastructure that referenced this pull request Feb 10, 2026
This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [element-hq/synapse](https://github.com/element-hq/synapse) | minor | `1.146.0` → `1.147.0` |

---

### Release Notes

<details>
<summary>element-hq/synapse (element-hq/synapse)</summary>

### [`v1.147.0`](https://github.com/element-hq/synapse/releases/tag/v1.147.0)

[Compare Source](element-hq/synapse@v1.146.0...v1.147.0)

### Synapse 1.147.0 (2026-02-10)

No significant changes since 1.147.0rc1.

### Synapse 1.147.0rc1 (2026-02-03)

#### Bugfixes

- Fix memory leak caused by not cleaning up stopped looping calls. Introduced in v1.140.0. ([#&#8203;19416](element-hq/synapse#19416))
- Fix a typo that incorrectly made `setuptools_rust` a runtime dependency. ([#&#8203;19417](element-hq/synapse#19417))

#### Internal Changes

- Prune stale entries from `sliding_sync_connection_required_state` table. ([#&#8203;19306](element-hq/synapse#19306))
- Update "Event Send Time Quantiles" graph to only use dots for the event persistence rate (Grafana dashboard). ([#&#8203;19399](element-hq/synapse#19399))
- Update and align Grafana dashboard to use regex matching for `job` selectors (`job=~"$job"`) so the "all" value works correctly across all panels. ([#&#8203;19400](element-hq/synapse#19400))
- Don't retry joining partial state rooms all at once on startup. ([#&#8203;19402](element-hq/synapse#19402))
- Disallow requests to the health endpoint from containing trailing path characters. ([#&#8203;19405](element-hq/synapse#19405))
- Add notes that new experimental features should have associated tracking issues. ([#&#8203;19410](element-hq/synapse#19410))
- Bump `pyo3` from 0.26.0 to 0.27.2 and `pythonize` from 0.26.0 to 0.27.0. Contributed by [@&#8203;razvp](https://github.com/razvp) @&#8203; ERCOM. ([#&#8203;19412](element-hq/synapse#19412))

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0My4zLjYiLCJ1cGRhdGVkSW5WZXIiOiI0My4zLjYiLCJ0YXJnZXRCcmFuY2giOiJtYWluIiwibGFiZWxzIjpbImltYWdlIl19-->

Reviewed-on: https://gitea.alexlebens.dev/alexlebens/infrastructure/pulls/3877
Co-authored-by: Renovate Bot <renovate-bot@alexlebens.net>
Co-committed-by: Renovate Bot <renovate-bot@alexlebens.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants