Fix a typo in check_dependencies.py which makes setuptools_rust a running dependency

[renaudallard]

Pull Request Checklist

• Pull request is based on the develop branch
• Code style is correct (run the linters)

There is a typo in check_dependencies.py which makes setuptools_rust a runtime requirement, but there is no need for it at runtime. This patch solves the typo. I tested starting 1.146.0 with this patch and without setuptools_rust and it starts correctly

[CLAassistant]

All committers have signed the CLA.

[anoadragon453]

Thanks for your contribution! A couple notes:

• This appears to make tests.util.test_check_dependencies.TestDependencyChecker.test_setuptools_rust_ignored fail. Is the test wrong?
• The issue that the code in question links to (python-poetry/poetry#6154) seems to be closed. Can this workaround be dropped instead?

Even though we switched to maturin as the build backend, we still make use of setuptools_rust so that poetry install can continue to work. But @renaudallard you may not have run into issues on this branch unless you cleared your build cache and ran poetry install --extras all?

[renaudallard]

My fix was enough to solve the dependency in OpenBSD ports system, but it indeed fails on tests. I have implemented a patch on the OpenBSD ports system for synapse (https://cvsweb.openbsd.org/cgi-bin/cvsweb/ports/net/synapse/), but having it upstream would solve the issue in a proper way.

While poetry#6154 was fixed in Poetry 1.6.0, that fix only applies to poetry install.
System package managers (e.g., OpenBSD's py3-synapse) use pip with poetry-core as the build backend, which still exposes build dependencies as runtime dependencies. Without this workaround, Synapse refuses to start on these systems unless setuptools-rust is installed as a runtime dependency. So the workaround is still necessary unfortunately.

[devonh]

@renaudallard Are you able to sign the CLA so we can merge this PR?

[renaudallard]

Sure, it's done

[devonh]

Thanks for taking the time to do this and make Synapse better for all packagers.