Skip to content

Re-usable Complement GitHub CI workflow#19533

Merged
MadLittleMods merged 15 commits intodevelopfrom
madlittlemods/reusable-complement-workflow
Apr 13, 2026
Merged

Re-usable Complement GitHub CI workflow#19533
MadLittleMods merged 15 commits intodevelopfrom
madlittlemods/reusable-complement-workflow

Conversation

@MadLittleMods
Copy link
Copy Markdown
Contributor

@MadLittleMods MadLittleMods commented Mar 6, 2026

As suggested by @anoadragon453,

Re-usable Complement GitHub CI workflow

Dev notes

Pull Request Checklist

  • Pull request is based on the develop branch
  • Pull request includes a changelog file. The entry should:
    • Be a short description of your change which makes sense to users. "Fixed a bug that prevented receiving messages from other servers." instead of "Moved X method from EventStore to EventWorkerStore.".
    • Use markdown where necessary, mostly for code blocks.
    • End with either a period (.) or an exclamation mark (!).
    • Start with a capital letter.
    • Feel free to credit yourself, by adding a sentence "Contributed by @github_username." or "Contributed by [Your Name]." to the end of the entry.
  • Code style is correct (run the linters)

Comment thread .github/workflows/complement_tests.yml Fixed
Comment on lines +7 to +12
use_latest_deps:
type: boolean
default: false
use_twisted_trunk:
type: boolean
default: false
Copy link
Copy Markdown
Contributor Author

@MadLittleMods MadLittleMods Mar 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tried out use_latest_deps and use_twisted_trunk in some CI runs and they appear to work. I don't know if the versions are actually being changed as expected.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • twisted_trunk: Updating twisted (25.5.0 -> 25.5.0.post0 508c44f) in the patch dependencies step, seems good

  • latest_deps: less obvious to see but

    #23 [requirements 4/4] RUN --mount=type=cache,target=/root/.cache/uv if [ -z "1" ]; then uvx --with poetry-plugin-export==1.9.0 poetry@2.1.1 export --extras all -o /synapse/requirements.txt ; else touch /synapse/requirements.txt; fi

    #23 DONE 0.2s sounds like it

@MadLittleMods MadLittleMods marked this pull request as ready for review March 9, 2026 14:57
@MadLittleMods MadLittleMods requested a review from a team as a code owner March 9, 2026 14:57
Copy link
Copy Markdown
Contributor

@reivilibre reivilibre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have cut and diffed locally to be sure the move didn't lose anything and I'm satisfied

Conflicts:
	.github/workflows/latest_deps.yml
	.github/workflows/tests.yml
	.github/workflows/twisted_trunk.yml

Resolve conflicts with `actions/setup-go`
@MadLittleMods MadLittleMods merged commit 1a94960 into develop Apr 13, 2026
46 checks passed
@MadLittleMods MadLittleMods deleted the madlittlemods/reusable-complement-workflow branch April 13, 2026 22:03
@MadLittleMods
Copy link
Copy Markdown
Contributor Author

Thanks for the review @reivilibre 🦫

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants