Hide successful, skipped Complement tests in the CI#19590
Merged
anoadragon453 merged 12 commits intodevelopfrom Mar 23, 2026
Merged
Hide successful, skipped Complement tests in the CI#19590anoadragon453 merged 12 commits intodevelopfrom
anoadragon453 merged 12 commits intodevelopfrom
Conversation
So the formatted Complement output isn't incredibly long. I never find myself looking at the successful test output anyways, but if one wants to, they can still view the output of the previous step.
This flag only works if you're not customising the default `gotestfmt` template, which we do via `.ci/complement_package.gotpl`.
Without this, setting `HideSuccessfulTests` via the `-hide` argument would do nothing.
I was confused otherwise. Also clearly document that successful tests are hidden, in case folks are confused why they may see no or few tests running.
While this script is clean, it is unused and currently a source of noise.
Complement has not depended on libolm for years. There's no need to keep installing it.
anoadragon453
changed the title
Our CI is supposed to be flaky, damnit!
This reverts commit 829bebd.
MadLittleMods
approved these changes
Mar 20, 2026
| @@ -0,0 +1 @@ | |||
| Only show failing Complement tests in the formatted output in CI. No newline at end of file | |||
Contributor
There was a problem hiding this comment.
Cross-linking the original context where this change is spawning from in the 2026-01-05 weekly backend team meeting.
While discussing #19326, @anoadragon453 mentioned "Since we have a file with the test output now, should we also filter things down to only the failing tests?" and I said "Sounds like a good follow-up especially since that collapsible section output is so laggy in the GitHub UI"
Co-authored-by: Eric Eastwood <erice@element.io>
The earlier version made it sound like our template was interpreting the value of `-hide` directly.
MadLittleMods
added a commit
that referenced
this pull request
Mar 30, 2026
Conflicts: .github/workflows/tests.yml Resolve conflicts from #19590
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So that the formatted Complement output isn't incredibly long. I never find myself looking at the successful test output anyways, but if one wants to, they can still view the output of the previous step.
This will be more-and-more necessary as we add more tests to Complement over time.
You can see the result of the changes in this CI run (only the failing tests are shown).
The package definitions of entirely-passing runs are still left in, but I figured they were minor (and it's still useful to see which packages are running).
Pull Request Checklist
EventStoretoEventWorkerStore.".code blocks.