-
Notifications
You must be signed in to change notification settings - Fork 522
Hide successful, skipped Complement tests in the CI #19590
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
anoadragon453
merged 12 commits into
develop
from
anoa/complement_hide_successful_tests
Mar 23, 2026
Merged
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
3e4e750
Hide successful Complement tests in the CI
anoadragon453 6596b95
newsfile
anoadragon453 2a93a41
Remove `-hide` flag from `gotestfmt` invocation
anoadragon453 948d863
Implement `successful-tests` option in our custom template
anoadragon453 1547db2
Document that the template exists and `-hide` depends on it
anoadragon453 5520727
Remove .ci/scripts/gotestfmt`
anoadragon453 590c60f
Remove `libolm` from Complement dependencies
anoadragon453 cd02a81
Additionally hide skipped tests
anoadragon453 829bebd
Purposefully break some Complement tests
anoadragon453 6e66d89
Revert "Purposefully break some Complement tests"
anoadragon453 0d841a9
Apply suggestions from code review
anoadragon453 8c21d14
Clarify `gotestfmt` -> template comment
anoadragon453 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| Only show failing Complement tests in the formatted output in CI. | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cross-linking the original context where this change is spawning from in the 2026-01-05 weekly backend team meeting.
While discussing #19326, @anoadragon453 mentioned "Since we have a file with the test output now, should we also filter things down to only the failing tests?" and I said "Sounds like a good follow-up especially since that collapsible section output is so laggy in the GitHub UI"