Merged
Conversation
The inspector used to support filtering out components in the view tab, and there are a lot of supporting code for that. Since the view tab was removed, there is no longer any way to set this option, and it is always true in practice.
wycats
force-pushed
the
rm-components-options
branch
from
7d07a57 to
9892ccd
Compare
RobbieTheWagner
approved these changes
Nov 8, 2019
This property contains the "full" class name string, something like `<app@component:textarea::ember545>` as opposed to `textarea`. It is only set but never read by anything.
This method is defined but never used. It is also the only thing that reads the `isVirtual` property, which is an Ember 1.0-ism that is no longer needed.
Most of the job of view-debug has already been moved to glimmer-tree, leaving behind a lot of code that was never called.
Contributor
|
🎉 |
patricklx
pushed a commit
to patricklx/ember-inspector
that referenced
this pull request
Sep 19, 2022
* Remove unused options The inspector used to support filtering out components in the view tab, and there are a lot of supporting code for that. Since the view tab was removed, there is no longer any way to set this option, and it is always true in practice. * Remove unused `completeViewClass` property This property contains the "full" class name string, something like `<app@component:textarea::ember545>` as opposed to `textarea`. It is only set but never read by anything. * Remove unused `shouldShowView` method This method is defined but never used. It is also the only thing that reads the `isVirtual` property, which is an Ember 1.0-ism that is no longer needed. * Remove a lot (!) of unused code! Most of the job of view-debug has already been moved to glimmer-tree, leaving behind a lot of code that was never called.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The inspector used to support filtering out components in the view tab, and there are a lot of supporting code for that. Since the view tab was removed, there is no longer any way to set this option, and it is always true in practice.