Skip to content

feat(i18n): Improve Spanish warning for non-ASCII characters#989

Closed
imrulo wants to merge 2 commits intoensdomains:mainfrom
imrulo:main
Closed

feat(i18n): Improve Spanish warning for non-ASCII characters#989
imrulo wants to merge 2 commits intoensdomains:mainfrom
imrulo:main

Conversation

@imrulo
Copy link
Copy Markdown
Contributor

@imrulo imrulo commented Apr 20, 2025

Purpose

This PR improves the warning message for Spanish speakers using valid characters (á, é, í, ó, ú, ü, ñ) in ENS names:

  • Reduces false alarms for correct Spanish orthography
  • Educates users about character preservation
  • References Unicode TR36 for technical accuracy

Changes

  • Added complete list of Spanish diacritics
  • Clear examples: «canción.eth» ≠ «cancion.eth»
  • Compatibility warnings for legacy systems

References

  • Unicode TR36 (Confusable Characters)
  • Related discussion: #1652 (legacy app PR)

imrulo and others added 2 commits February 12, 2025 18:26
Corrección de traducción: "en web3" en lugar de "de web 3"
@imrulo imrulo requested a review from sugh01 as a code owner April 20, 2025 22:44
@sonarqubecloud
Copy link
Copy Markdown

@laurgk
Copy link
Copy Markdown
Contributor

laurgk commented Apr 25, 2025

Thank you for this - tested and merged here: #994

Closing this PR now :)

@laurgk laurgk closed this Apr 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants