Skip to content

feat(i18n): Improve Spanish warning for non-ASCII characters#994

Merged
laurgk merged 4 commits intomainfrom
devin/1745497296-spanish-warning-improvement
Apr 25, 2025
Merged

feat(i18n): Improve Spanish warning for non-ASCII characters#994
laurgk merged 4 commits intomainfrom
devin/1745497296-spanish-warning-improvement

Conversation

@devin-ai-integration
Copy link
Copy Markdown
Contributor

Improve Spanish warning for non-ASCII characters

Purpose

This PR improves the warning message for Spanish speakers using valid characters (á, é, í, ó, ú, ü, ñ) in ENS names:

  • Reduces false alarms for correct Spanish orthography
  • Educates users about character preservation
  • References Unicode TR36 for technical accuracy

Changes

  • Added complete list of Spanish diacritics
  • Clear examples: «canción.eth» ≠ «cancion.eth»
  • Compatibility warnings for legacy systems

References

  • Unicode TR36 (Confusable Characters)
  • Related discussion: #1652 (legacy app PR)

Link to Devin run: https://app.devin.ai/sessions/4e58d91eb8ef42c78b1f5035a615a972
Requested by: Laura Markowska (laura@ens.domains)

Co-Authored-By: Laura Markowska <laura@ens.domains>
@devin-ai-integration
Copy link
Copy Markdown
Contributor Author

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

devin-ai-integration bot and others added 3 commits April 24, 2025 12:35
Co-Authored-By: Laura Markowska <laura@ens.domains>
Co-Authored-By: Laura Markowska <laura@ens.domains>
Co-Authored-By: Laura Markowska <laura@ens.domains>
@sonarqubecloud
Copy link
Copy Markdown

Copy link
Copy Markdown
Contributor

@laurgk laurgk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested.

@laurgk laurgk merged commit 6c40205 into main Apr 25, 2025
39 checks passed
@laurgk laurgk deleted the devin/1745497296-spanish-warning-improvement branch April 25, 2025 08:34
@imrulo
Copy link
Copy Markdown
Contributor

imrulo commented Apr 25, 2025

Gracias

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants