Conversation
21592ca to
a68d071
Compare
Test Results32 tests 32 ✅ 1m 35s ⏱️ Results for commit 87963dc. ♻️ This comment has been updated with latest results. |
68f5b7e to
6095af1
Compare
6095af1 to
3d4ca37
Compare
3d4ca37 to
5e44436
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 5e44436. Configure here.
| usb_host_task = NULL; | ||
| } | ||
| return ESP_OK; | ||
| } |
There was a problem hiding this comment.
USB host uninstalled before event task stopped
Medium Severity
bsp_usb_host_stop calls usb_host_uninstall() before suspending/deleting the usb_lib_task. The task may still be blocked in usb_host_lib_handle_events() when the host is uninstalled, leading to a crash or undefined behavior. The task needs to be stopped before uninstalling the USB host library.
Reviewed by Cursor Bugbot for commit 5e44436. Configure here.
bb757af to
aee5b3b
Compare
aee5b3b to
87963dc
Compare


ESP-BSP Pull Request checklist
Description
M5Stack CoreS3esp_videodisplay_cameraexample (using oldesp32_camera- no more boards are use it)BMI270display_camera_videoexampleM5Stack CoreS3fromdisplay_rotationexample (due to using another IMU and this example should be reworked for it)Closes #728
Closes #729
Closes #754
Related to #374 - it should be fixed too.
Note
Medium Risk
Substantial refactor of the
m5stack_core_s3BSP into new per-peripheral modules and APIs (display lifecycle, feature power control, sensors/USB), plus a camera stack migration toesp_video, which may affect initialization order and shared SPI/I2C behavior across examples.Overview
Regenerates the
m5stack_core_s3BSP by replacing the monolithic implementation with modular sources (bsp_display,bsp_i2c,bsp_spi,bsp_storage,bsp_audio,bsp_camera,bsp_usb,bsp_sensors) and bumping the component to4.0.0with new dependencies (IO expander,esp_video, USB host, BMI270).Updates the public API surface: adds
bsp_i2c_get_handle(), SPI init/deinit APIs, display lifecycle helpers (bsp_display_new_with_handles(),bsp_display_delete(), sleep entry/exit, brightness deinit), a unifiedbsp_feature_enable()power-control layer (AXP2101 + AW9523),bsp_camera_start(), and sensor-hub basedbsp_sensor_init()(IMU enabled).Example/CI churn: removes legacy
examples/display_camera(and drops it from Kaluga docs), adds a pytest smoke test forexamples/display_camera_videoand runs it in CI, updates example sdkconfigs for CoreS3 (camera/video, sdcard, sensors), and refreshes top-level README tables to reflect CoreS3 camera/IMU and example support changes.Sensor driver tweak: bumps
bmi270component to1.0.1and increases power-on/soft-reset delays to improve init reliability.Reviewed by Cursor Bugbot for commit 87963dc. Bugbot is set up for automated code reviews on this repo. Configure here.