Skip to content

[ENG-15002][eas-cli] fingerprint:generate#2937

Merged
quinlanj merged 7 commits intomainfrom
03-08-_eas-cli_fingerprint_generate
Mar 18, 2025
Merged

[ENG-15002][eas-cli] fingerprint:generate#2937
quinlanj merged 7 commits intomainfrom
03-08-_eas-cli_fingerprint_generate

Conversation

@quinlanj
Copy link
Copy Markdown
Member

@quinlanj quinlanj commented Mar 8, 2025

Why

First pass of eas fingerprint:generate in hidden mode.

  • Interactive fingerprint generation:
    eas fingerprint:generate
Screenshot 2025-03-16 at 6 31 51 PM
  • Non Interactive fingerprint generation:
    eas fingerprint:generate --json --non-interactive -p android
    Will print the fingerprint json to stdout

Test Plan

  • ran eas fingerprint:generate
  • ran eas fingerprint:generate --json --non-interactive -p android

@quinlanj quinlanj changed the title [eas-cli] fingerprint:generate [ENG-15002][eas-cli] fingerprint:generate Mar 8, 2025
Copy link
Copy Markdown
Member Author

quinlanj commented Mar 8, 2025

@linear
Copy link
Copy Markdown

linear bot commented Mar 8, 2025

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 8, 2025

❌ It looks like a changelog entry is missing for this PR. Add it manually to CHANGELOG.md.
⏩ If this PR doesn't require a changelog entry, such as if it's an internal change that doesn't affect the user experience, you can add the "no changelog" label to the PR.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 8, 2025

Size Change: -447 B (0%)

Total Size: 53.4 MB

Filename Size Change
./packages/eas-cli/dist/eas-linux-x64.tar.gz 53.4 MB -447 B (0%)

compressed-size-action

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 8, 2025

Codecov Report

Attention: Patch coverage is 34.28571% with 69 lines in your changes missing coverage. Please review.

Project coverage is 52.64%. Comparing base (ef8d6d0) to head (16360ca).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
packages/eas-cli/src/fingerprint/utils.ts 20.00% 44 Missing ⚠️
...kages/eas-cli/src/commands/fingerprint/generate.ts 43.91% 23 Missing ⚠️
...ckages/eas-cli/src/commands/fingerprint/compare.ts 60.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2937      +/-   ##
==========================================
- Coverage   52.65%   52.64%   -0.00%     
==========================================
  Files         588      590       +2     
  Lines       23252    23300      +48     
  Branches     4629     4634       +5     
==========================================
+ Hits        12240    12265      +25     
- Misses      10978    11001      +23     
  Partials       34       34              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@quinlanj quinlanj force-pushed the 03-08-_eas-cli_fingerprint_generate branch from e2c1152 to ff9843d Compare March 16, 2025 07:39
@quinlanj quinlanj marked this pull request as ready for review March 16, 2025 07:40
@github-actions
Copy link
Copy Markdown

Subscribed to pull request

File Patterns Mentions
**/* @szdziedzic, @khamilowicz, @sjchmiela, @radoslawkrzemien

Generated by CodeMention

@quinlanj quinlanj force-pushed the 03-08-_eas-cli_fingerprint_generate branch from 50c1faa to 68a8a3e Compare March 17, 2025 23:24
@quinlanj quinlanj merged commit f297df7 into main Mar 18, 2025
10 checks passed
@quinlanj quinlanj deleted the 03-08-_eas-cli_fingerprint_generate branch March 18, 2025 00:11
...optionsFromWorkflow,
platforms: platforms.map(appPlatformToString),
debug: true,
env: undefined,
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

an unrelated point here. some people use eas env var in their app config. passing undefined env may cause inconsistent fingerprint between local and server. i resolved that for eas update command from #2867

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

heads up @quinlanj

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants