[eas-cli] add support for build profiles in fingerprint generation

[quinlanj]

How you can help

This is my current understanding of how a build profile can affect a project's fingerprint. @szdziedzic and @sjchmiela, please let me know if it is correct, or if there are any nuances I am missing!

• A fingerprint contains the following components which we use to determine compatibility at an app's native layer
• In eas.json, we have a bunch of build profiles which define a bunch of parameters like build machine types, update channels, etc. However, it is the set of environment variables produced (specifying build profile parameter as input) which ultimately affects the fingerprint. Is there any other way a build profile can affect a fingerprint?

For example, I can define the TEST env var to differ based on the build profile that is chosen:

Next, I configure my app.config.js to determine the bundleIdentifier based on the TEST env var:

function getBundleIdentifier() {
  if (process.env.TEST === "production") {
    return "com.quintest110.stagingsdk52.production";
  } else if (process.env.TEST === "development") {
    return "com.quintest110.stagingsdk52.development";
  } else if (process.env.TEST === "preview") {
    return "com.quintest110.stagingsdk52.preview";
  }
  return "com.quintest110.stagingsdk52";
}

Since the fingerprint relies on the app config, I can see the fingerprint is changed when I run eas fingerprint:generate -p ios --profile production vs eas fingerprint:generate -p ios --profile development here

Why

This PR adds support for build profiles in eas fingeprint:generate by allowing the user to pass in the --profile flag.

How

After a build profile is chosen, the cli takes the generated Env and temporarily sets those env vars while calculating the fingerprint

Tests

• Different fingerprints with expected diffs are generated with eas fingerprint:generate -p ios --profile production vs eas fingerprint:generate -p ios --profile development here

[quinlanj]

• [eas-cli] add support for build profiles in fingerprint generation #2951 👈 (View in Graphite)
• [ENG-15002][eas-cli] fingerprint:generate #2937
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[github-actions]

Size Change: +977 B (0%)

Total Size: 53.4 MB

Filename	Size	Change
./packages/eas-cli/dist/eas-linux-x64.tar.gz	53.4 MB	+977 B (0%)

_{compressed-size-action}

[codecov]

Codecov Report

Attention: Patch coverage is 6.25000% with 15 lines in your changes missing coverage. Please review.

Project coverage is 52.61%. Comparing base (4e8fc05) to head (05281af).
Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
packages/eas-cli/src/fingerprint/cli.ts	0.00%	8 Missing ⚠️
...kages/eas-cli/src/commands/fingerprint/generate.ts	14.29%	6 Missing ⚠️
packages/eas-cli/src/fingerprint/utils.ts	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2951      +/-   ##
==========================================
- Coverage   52.64%   52.61%   -0.03%     
==========================================
  Files         590      590              
  Lines       23300    23310      +10     
  Branches     4634     4638       +4     
==========================================
- Hits        12265    12263       -2     
- Misses      11001    11013      +12     
  Partials       34       34              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[github-actions]

Subscribed to pull request

File Patterns	Mentions
**/*	@szdziedzic, @khamilowicz, @sjchmiela, @radoslawkrzemien

Generated by CodeMention

[wschurman]

How does this relate to EAS Environment Variables? (the environment flag in eas update). I was under the assumption that we didn't add the environment flag to eas build since this was specified in the eas json profile and they were automatically loaded. As a point of reference, for doing something similar in the github action we use eas env:exec: https://github.com/expo/expo-github-action/blob/main/src/fingerprintUtils.ts#L72

[wschurman]

(requesting changes mainly to put back on your queue for discussion of environment variables, not for inline comments)

[quinlanj]

@wschurman makes sense (i see this pattern in a lot of other eas cli commands too), i updated the command so that it takes the environment arg instead of profile.

[wschurman]

Suggested change

	let env: Env | undefined;
	if (environment) {
	env = environment
	? { ...(await getServerSideEnvironmentVariablesAsync()), EXPO_NO_DOTENV: '1' }
	: {};
	}
	const env = environment
	? { ...(await getServerSideEnvironmentVariablesAsync()), EXPO_NO_DOTENV: '1' }
	: undefined;

[wschurman]

Also regarding EXPO_NO_DOTENV, I see this is the behavior for eas update for calling into the expo cli (which I assume fingerprint does under the hood hence why we add it to this call), but is it also the behavior for eas build?

[quinlanj]

i passed EXPO_NO_DOTENV because it is also passed to grab the config elsewhere in eas-cli (npx expo config is a shim over expo/config):

eas-cli/packages/eas-cli/src/project/expoConfig.ts

Lines 59 to 72 in 22bc21e

	try {
	const { stdout } = await spawnAsync(
	'npx',
	['expo', 'config', '--json', ...(opts.isPublicConfig ? ['--type', 'public'] : [])],
	{
	cwd: projectDir,
	env: {
	...process.env,
	...opts.env,
	EXPO_NO_DOTENV: '1',
	},
	}
	);

under the hood, the fingerprint library calls into the expo/config library

eas-cli/packages/eas-cli/src/project/expoConfig.ts

Lines 59 to 72 in 22bc21e

	try {
	const { stdout } = await spawnAsync(
	'npx',
	['expo', 'config', '--json', ...(opts.isPublicConfig ? ['--type', 'public'] : [])],
	{
	cwd: projectDir,
	env: {
	...process.env,
	...opts.env,
	EXPO_NO_DOTENV: '1',
	},
	}
	);