Skip to content

[eas-cli] add environment support for fingerprint:compare#2954

Merged
quinlanj merged 1 commit intomainfrom
03-18-_eas-cli_add_build_profile_support_for_fingerprint_compare
Mar 26, 2025
Merged

[eas-cli] add environment support for fingerprint:compare#2954
quinlanj merged 1 commit intomainfrom
03-18-_eas-cli_add_build_profile_support_for_fingerprint_compare

Conversation

@quinlanj
Copy link
Copy Markdown
Member

@quinlanj quinlanj commented Mar 18, 2025

Why

Add environment support for eas fingerprint:compare, similar to #2951 .

Test Plan

  • Interactive mode picks up environment: EXPO_STAGING=1 ~/Documents/eas-cli/packages/eas-cli/bin/run fingerprint:compare --environment production
  • Specified flags are picked up: EXPO_STAGING=1 ~/Documents/eas-cli/packages/eas-cli/bin/run fingerprint:compare --environment production 141250064aa05217358003c179d5a5d57c6a5b4b

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 18, 2025

Size Change: -2.61 kB (0%)

Total Size: 53.5 MB

Filename Size Change
./packages/eas-cli/dist/eas-linux-x64.tar.gz 53.5 MB -2.61 kB (0%)

compressed-size-action

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 18, 2025

Codecov Report

Attention: Patch coverage is 6.66667% with 14 lines in your changes missing coverage. Please review.

Project coverage is 52.62%. Comparing base (fb33298) to head (80c3493).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...ckages/eas-cli/src/commands/fingerprint/compare.ts 7.70% 12 Missing ⚠️
...kages/eas-cli/src/commands/fingerprint/generate.ts 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2954      +/-   ##
==========================================
- Coverage   52.64%   52.62%   -0.01%     
==========================================
  Files         590      590              
  Lines       23322    23330       +8     
  Branches     4638     4643       +5     
==========================================
  Hits        12275    12275              
- Misses      11013    11021       +8     
  Partials       34       34              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@quinlanj quinlanj force-pushed the 03-16-_eas-cli_add_support_for_build_profiles_in_fingerprint_generation branch from 8cd7554 to bfc296d Compare March 21, 2025 14:47
Base automatically changed from 03-16-_eas-cli_add_support_for_build_profiles_in_fingerprint_generation to main March 21, 2025 19:21
@quinlanj quinlanj changed the title [eas-cli] add build profile support for fingerprint:compare [eas-cli] add environment support for fingerprint:compare Mar 21, 2025
@quinlanj quinlanj force-pushed the 03-18-_eas-cli_add_build_profile_support_for_fingerprint_compare branch from 821f132 to 3b24a69 Compare March 21, 2025 19:56
@quinlanj quinlanj marked this pull request as ready for review March 21, 2025 19:59
@quinlanj quinlanj requested a review from wschurman March 21, 2025 19:59
@github-actions
Copy link
Copy Markdown

Subscribed to pull request

File Patterns Mentions
**/* @szdziedzic, @khamilowicz, @sjchmiela, @radoslawkrzemien

Generated by CodeMention

@quinlanj quinlanj requested a review from sjchmiela March 21, 2025 19:59
@quinlanj quinlanj force-pushed the 03-18-_eas-cli_add_build_profile_support_for_fingerprint_compare branch from 3b24a69 to 80c3493 Compare March 26, 2025 19:27
@quinlanj quinlanj merged commit 5236de7 into main Mar 26, 2025
9 checks passed
@quinlanj quinlanj deleted the 03-18-_eas-cli_add_build_profile_support_for_fingerprint_compare branch March 26, 2025 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants