Prevent Multiple Errors from Crashing#380
Merged
LinusU merged 1 commit intoexpressjs:masterfrom Dec 14, 2016
Merged
Conversation
|
Why is this not in the latest version?! |
Member
|
Sorry, must have missed this, merging now |
This was referenced Dec 14, 2016
LinusU
added a commit
that referenced
this pull request
Dec 22, 2016
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When you have an upload that has more than one error, seemingly only with disk storage, it causes the node process to crash. More details here - #335
Tests should showcase an example of this, along with a potential fix.