Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions lib/make-middleware.js
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,7 @@ function makeMiddleware (setup) {
}

function abortWithError (uploadError) {
if (errorOccured) return
errorOccured = true

pendingWrites.onceZero(function () {
Expand Down
17 changes: 17 additions & 0 deletions test/error-handling.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

var assert = require('assert')

var os = require('os')
var util = require('./_util')
var multer = require('../')
var stream = require('stream')
Expand Down Expand Up @@ -203,4 +204,20 @@ describe('Error Handling', function () {
done()
})
})

it('should gracefully handle more than one error at a time', function (done) {
var form = new FormData()
var storage = multer.diskStorage({ destination: os.tmpdir() })
var upload = multer({ storage: storage, limits: { fileSize: 1, files: 1 } }).fields([
{ name: 'small0', maxCount: 1 }
])

form.append('small0', util.file('small0.dat'))
form.append('small0', util.file('small0.dat'))

util.submitForm(upload, form, function (err, req) {
assert.equal(err.code, 'LIMIT_FILE_SIZE')
done()
})
})
})