Skip to content

The imgAlignSide component only has a margin-right #397

@cyan33

Description

@cyan33

Is this a bug report?

bug

(write your answer here)

Have you read the Contributing Guidelines?

(Write your answer here.)
Yes

Expected Behavior

I found this issue originally in the jest website. And after some discussion we figured that it would be ideal to fix this issue in the upstream.

If you look at the website of docusaurus, when the text is on the right side, the blockImage has a right margin in between, which is a margin-right:

image

However, when the text is on the left side, the blockImage doesn't fit this margin to a margin-left, which leaves no space in between the image and block text:

image

And in the jest website, it looks ugly when the boundary is obvious to note this issue:

image

I think it would be ideal to add a parameter to the component to specify where should be the margin added, like left or right.

I'd love to fix this issue and submit a PR if it is recognized. 😄

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions