Fix margin for right-aligned images#398
Conversation
|
@rickhanlonii It's alright! Happy to see this get fixed! 😄 |
|
On second thought tho, I think it's better to separate the |
|
I had the same thought, I'll update |
|
Updated, that's much cleaner thanks @cyan33 |
|
@rickhanlonii Thank you so much for taking the time to fix this. Looks good to me. And thanks @cyan33 for raising the issue too. |
|
@JoelMarcey No problem! 😄 |
JoelMarcey
left a comment
There was a problem hiding this comment.
Looks great.
At first I thought about whether imageAlignSide is actually necessary (not taking into consideration it would be a breaking change if we took it out). But I think it works like this.
Motivation
@cyan33 found this bug and submitted it to the Jest repo, I thought I'd put in a quick fix
Closes jestjs/jest#5299
Closes #397
Test Plan
Tested using the
website/within this projectBefore:
After: