Upload 2.0 support for data library creation.#89
Upload 2.0 support for data library creation.#89bgruening merged 5 commits intogalaxyproject:masterfrom
Conversation
aed3eb3 to
350a9ba
Compare
|
If we really want to support the old format as well we should add a test with the old file to https://github.com/galaxyproject/ephemeris/blob/master/tests/test_workflow_and_data.sh#L20 |
|
Yeah - I added a file to do that but forgot to update the test. I'll do that. |
| [flake8] | ||
| max-line-length = 150 | ||
| max-complexity = 30 | ||
| ignore = E501 |
There was a problem hiding this comment.
Long URLs are ignored by standard. So I cannot see a reason why line length should be ignored.
|
Pull request looks very nice. Travis only fails on a few linting errors. |
Will convert older style library YAML format to modern version, will attempt to implement a subset of the modern format with legacy APIs as needed.
aade4be to
a37e4c8
Compare
We essentially don't want to change the Galaxy API to loose the URL (galaxyproject/galaxy#3695, galaxyproject/galaxy#3996), we tried at some point and had to revert it. The new upload API is smart though and can be used to set a name at upload time and embed the URL we may want to have around later in the info of the dataset. I'd prefer to make this explicit in format if that is okay, so it remains a proper superset of the real API format - I've added an example of doing that here. Unfortunately for the legacy API, this will not work because we aren't exposing the name option in bioblend's library upload options.
Added an example of how to do that and explained why I'd prefer not to make it automatic in this commit's comment: |
|
Thanks @jmchilton! |
Will convert older style library YAML format from ephemeris to modern version, will attempt to implement a subset of the modern format with legacy APIs as needed.
Some of the defaults that only made sense for training data have been hidden behind a new
--trainingflag.