Skip to content

[25.1] Fix GCard Layout and White Spaces#21026

Merged
guerler merged 8 commits intogalaxyproject:release_25.1from
itisAliRH:fix-g-card-white-space
Oct 10, 2025
Merged

[25.1] Fix GCard Layout and White Spaces#21026
guerler merged 8 commits intogalaxyproject:release_25.1from
itisAliRH:fix-g-card-white-space

Conversation

@itisAliRH
Copy link
Copy Markdown
Member

Closes #20997
This pull request updates the GCard component to improve the rendering and layout of descriptions and action buttons. The changes focus on better conditional rendering, improved spacing, and more consistent styling for descriptions and actions.

Before After
image image
image image
image image

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

Restructures description template logic to use cleaner conditional blocks and adds proper CSS class for styling control.

Optimizes action button rendering by adding length checks to prevent unnecessary DOM elements when no actions are present.

Adjusts margin classes to improve visual spacing consistency across
different action button configurations.

Adds scoped CSS rule to remove bottom margins from paragraph elements within card descriptions for better typography control.
@itisAliRH itisAliRH requested a review from guerler October 8, 2025 15:04
@github-actions github-actions Bot added this to the 26.0 milestone Oct 8, 2025
@itisAliRH itisAliRH modified the milestones: 26.0, 25.1 Oct 8, 2025
@guerler
Copy link
Copy Markdown
Contributor

guerler commented Oct 9, 2025

There are a few more inaccuracy. I created a separate ticket for it: #21030.

@itisAliRH
Copy link
Copy Markdown
Member Author

@guerler thanks for the changes! The upper border and the rename button position are also fixed.

@guerler guerler merged commit 16acd7f into galaxyproject:release_25.1 Oct 10, 2025
27 checks passed
@itisAliRH itisAliRH deleted the fix-g-card-white-space branch October 10, 2025 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants