Skip to content

Fix tool id handling for shed-installed tools#22553

Merged
mvdbeek merged 4 commits intogalaxyproject:devfrom
guerler:toolrequests.000
Apr 24, 2026
Merged

Fix tool id handling for shed-installed tools#22553
mvdbeek merged 4 commits intogalaxyproject:devfrom
guerler:toolrequests.000

Conversation

@guerler
Copy link
Copy Markdown
Contributor

@guerler guerler commented Apr 23, 2026

  1. Fix tool name construction for shed installed tools
  2. Coerce optional numeric params (integer/float/data_column) to None
  3. Add guard to encode id for optional data inputs

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@guerler guerler added this to the 26.1 milestone Apr 23, 2026
@guerler guerler changed the title Add guard to encode id for optional data params Fix tool id handling for shed-installed tools Apr 23, 2026
@guerler guerler marked this pull request as ready for review April 23, 2026 20:18
@mvdbeek mvdbeek merged commit 00a9eda into galaxyproject:dev Apr 24, 2026
68 of 70 checks passed
@guerler guerler deleted the toolrequests.000 branch April 24, 2026 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants