circos: add tar requirement#2714
Merged
mvdbeek merged 8 commits intogalaxyproject:masterfrom Dec 2, 2019
Merged
Conversation
mvdbeek
reviewed
Dec 1, 2019
Member
I think symlink should be fine for now, but we may want to place the config files into a separate, writable directory (on the Galaxy side). |
mvdbeek
reviewed
Dec 1, 2019
hexylena
reviewed
Dec 1, 2019
Member
hexylena
left a comment
hexylena
left a comment
There was a problem hiding this comment.
Replace the ln with cp and I'm fine with this.
hexylena
reviewed
Dec 2, 2019
| mv '$highlight_conf' circos/conf/highlight.conf && | ||
| mv '$links_conf' circos/conf/links.conf && | ||
| mv '$test_case_conf' circos/conf/galaxy_test_case.json && | ||
| cp -s '$circos_conf' circos/conf/circos.conf && |
Member
There was a problem hiding this comment.
the man page for -s reads make symbolic links instead of copying, isn't that explicitly what we're trying to avoid by switching to cp from ln?
nsoranzo
reviewed
Dec 2, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
seems that another problem is that the generated configfiles are moved to working/... which seems not to work in the container tests.
mv: can't remove '/tmp/tmpzvg40cuz/job_working_directory/000/2/tmpnuxq8_9j': Read-only file systemWe could try to cp or symlink? Or should this be fixes in another way
FOR CONTRIBUTOR: