Skip to content

kraken: test fixes#2721

Merged
bgruening merged 4 commits intogalaxyproject:masterfrom
bernt-matthias:topic/kraken-container-fixes
Dec 4, 2019
Merged

kraken: test fixes#2721
bgruening merged 4 commits intogalaxyproject:masterfrom
bernt-matthias:topic/kraken-container-fixes

Conversation

@bernt-matthias
Copy link
Copy Markdown
Contributor

Does not fix the error for kraken.xml:

docker: Error response from daemon: OCI runtime create failed: container_linux.go:346: starting container process caused "exec: \"/bin/bash\": stat /bin/bash: no such file or directory": unknown.
time="2019-11-30T21:47:30Z" level=error msg="error waiting for container: context canceled"

FOR CONTRIBUTOR:

  • - I have read the CONTRIBUTING.md document and this tool is appropriate for the tools-iuc repo.
  • - License permits unrestricted use (educational + commercial)
  • - This PR adds a new tool or tool collection
  • - This PR updates an existing tool or tool collection
  • - This PR does something else (explain below)

@mvdbeek
Copy link
Copy Markdown
Member

mvdbeek commented Dec 2, 2019

docker: Error response from daemon: OCI runtime create failed: container_linux.go:346: starting container process caused "exec: "/bin/bash": stat /bin/bash: no such file or directory": unknown.
time="2019-11-30T21:47:30Z" level=error msg="error waiting for container: context canceled"

might be due to an old biocontainers image, recent images should have bash. We could try to upgrade to 1.1.1, it seems there were no major changes introduced: https://github.com/DerrickWood/kraken/releases

@mvdbeek
Copy link
Copy Markdown
Member

mvdbeek commented Dec 3, 2019

I've bumped kraken to 1.1.1. Tests pass when not run in docker, but the data table data is symlinked to outside of the tool directory, which breaks when mounting the tool-data volume in docker.

@mvdbeek
Copy link
Copy Markdown
Member

mvdbeek commented Dec 3, 2019

I've restructured the kraken directory and used the advanced .shed.yml features to separate the tools into separate repos. This does pass containerized testing now.

@bgruening
Copy link
Copy Markdown
Member

@mvdbeek have you tested that against the TTS with the IUC account if everything is still ok?
I looks ok to me but I'm always worried with those changes to the shed.yml

@mvdbeek
Copy link
Copy Markdown
Member

mvdbeek commented Dec 4, 2019

Yes, it's all there and looks correct, e..g https://testtoolshed.g2.bx.psu.edu/view/devteam/kraken_filter/6e690205b306

@bgruening
Copy link
Copy Markdown
Member

Ok! Cool! Thanks so much!

@bgruening bgruening merged commit 0634550 into galaxyproject:master Dec 4, 2019
@bernt-matthias bernt-matthias deleted the topic/kraken-container-fixes branch March 8, 2020 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants