Skip to content

Add minimal wrapper for minia#2960

Merged
bgruening merged 6 commits into
galaxyproject:masterfrom
nsoranzo:minia
Apr 9, 2020
Merged

Add minimal wrapper for minia#2960
bgruening merged 6 commits into
galaxyproject:masterfrom
nsoranzo:minia

Conversation

@nsoranzo
Copy link
Copy Markdown
Member

@nsoranzo nsoranzo commented Apr 8, 2020

FOR CONTRIBUTOR:

  • - I have read the CONTRIBUTING.md document and this tool is appropriate for the tools-iuc repo.
  • - License permits unrestricted use (educational + commercial)
  • - This PR adds a new tool or tool collection
  • - This PR updates an existing tool or tool collection
  • - This PR does something else (explain below)

@bgruening
Copy link
Copy Markdown
Member

Mh, this new testing is not working. @bernt-matthias the test are actually failing, but are green :(

@bernt-matthias
Copy link
Copy Markdown
Contributor

bernt-matthias commented Apr 8, 2020

Hmm. tool_test_output.json actually contains the "failure" status. The step Check status of combined status (stupid name btw) should have determined this. Locally the code works for me.

Unfortunately I give a course tomorrow and won't have time. Maybe @nsoranzo can add the necessary debug statements to trace down and maybe fix the bug?

Maybe we should not merge anything until this is fixed?

@bgruening
Copy link
Copy Markdown
Member

@nsoranzo is on holidays from now on. Mh, strange.

@bernt-matthias
Copy link
Copy Markdown
Contributor

Then we should warn on the IUC gitter. If the html output is checked before merging its fine.

@bgruening
Copy link
Copy Markdown
Member

This one is failing ... #2961

@bernt-matthias
Copy link
Copy Markdown
Contributor

The step in question is here:

- name: Check status of combined status

I'm quite sure that I won't have time tomorrow.

@nsoranzo nsoranzo changed the title [WIP] Add wrapper for minia Add minimal wrapper for minia Apr 8, 2020
@nsoranzo
Copy link
Copy Markdown
Member Author

nsoranzo commented Apr 8, 2020

Good to go from my side, if you want to merge this very minimal version @bgruening

@nsoranzo
Copy link
Copy Markdown
Member Author

nsoranzo commented Apr 9, 2020

The step in question is here:

- name: Check status of combined status

I'm quite sure that I won't have time tomorrow.

I think I fixed it in 8f7ba27 , let me know if you want me to move the commit to a separate PR, but if @bgruening fix the tools in #2961 it would be a good test that it works.

@bgruening bgruening merged commit cd3b054 into galaxyproject:master Apr 9, 2020
@bgruening
Copy link
Copy Markdown
Member

Thanks a lot!

@nsoranzo nsoranzo deleted the minia branch April 11, 2020 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants