Fix file open mode for Python 3 and PEP-8 errors for data managers#3323
Merged
bernt-matthias merged 1 commit intogalaxyproject:masterfrom Nov 22, 2020
Merged
Conversation
Also: - prefer json `load()`/`dump()` to `loads()`/`dumps()` - use `with` statement to open/close files Close galaxyproject#2032
nsoranzo
changed the title
bgruening
approved these changes
Nov 21, 2020
Member
|
@nsoranzo thanks a lot. |
bernt-matthias
approved these changes
Nov 22, 2020
Contributor
bernt-matthias
left a comment
bernt-matthias
left a comment
There was a problem hiding this comment.
Great work. Good to have more consistency in the data managers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also:
load()/dump()toloads()/dumps()withstatement to open/close filesClose #2032
FOR CONTRIBUTOR: