Skip to content

New tool addition: Alnchain#7911

Open
as042 wants to merge 11 commits intogalaxyproject:mainfrom
as042:alnchain
Open

New tool addition: Alnchain#7911
as042 wants to merge 11 commits intogalaxyproject:mainfrom
as042:alnchain

Conversation

@as042
Copy link
Copy Markdown
Contributor

@as042 as042 commented Apr 20, 2026

FOR CONTRIBUTOR:

  • I have read the CONTRIBUTING.md document and this tool is appropriate for the tools-iuc repo.
  • License permits unrestricted use (educational + commercial)
  • This PR adds a new tool or tool collection
  • This PR updates an existing tool or tool collection
  • This PR does something else (explain below)

Adds ALNchain to the FastGA suite and adds thread control to FastGA.

@SaimMomin12
Copy link
Copy Markdown
Contributor

@as042 Could you please use VS Code Galaxy extension to format the wrapper appropriately?

Copy link
Copy Markdown
Member

@RZ9082 RZ9082 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks for the fasta.gz files which where used to produce the chrM_HGvMM.1aln input and it is not finding them. Specifically for the paths used in the FastGA command execution.
In you case: FastGA -1:test test-data/chrM_hg38.fa.gz test-data/chrM_mm39.fa.gz.

@as042
Copy link
Copy Markdown
Contributor Author

as042 commented Apr 22, 2026

@SaimMomin12 I did use the extension. Is something about it not formatted correctly because it didn't catch the errors?

@as042
Copy link
Copy Markdown
Contributor Author

as042 commented Apr 22, 2026

Today I learned that planemo test can pass, but the pr check still fails for some reason.

@bgruening
Copy link
Copy Markdown
Member

@as042 make sure you run planemo test --biocontainers ./tools/

Comment thread tools/fastga/alnchain.xml Outdated
Comment thread tools/fastga/alnchain.xml Outdated
Comment thread tools/fastga/fastga.xml Outdated
Comment thread tools/fastga/macros.xml Outdated
Comment thread tools/fastga/macros.xml Outdated
@SaimMomin12 SaimMomin12 changed the title Alnchain New tool addition: Alnchain Apr 22, 2026
Comment thread tools/fastga/alnchain.xml Outdated
Comment thread tools/fastga/alnchain.xml Outdated
cp 'output.1aln' '$output'
]]></command>
<inputs>
<param name="input" type="data" format="txt" label="Input .1aln alignment file"
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not think that txt is a good practice here. This would result into Error: Cannot count lines in dataset for the displayed job metadata.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed it to binary. Should I register 1aln as its own data format in Galaxy?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure about that. @bgruening?

Copy link
Copy Markdown
Contributor

@SaimMomin12 SaimMomin12 Apr 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed it to binary. Should I register 1aln as its own data format in Galaxy?

Yes, if you intend to use .1aln format in other tools as well, it would be worthwhile to create a new datatype here: https://github.com/galaxyproject/galaxy/blob/dev/lib/galaxy/config/sample/datatypes_conf.xml.sample

Comment thread tools/fastga/macros.xml Outdated
Comment thread tools/fastga/fastga.xml Outdated
Comment thread tools/fastga/fastga.xml Outdated
@as042
Copy link
Copy Markdown
Contributor Author

as042 commented Apr 22, 2026

I'm so confused. I barely changed anything since the CI passed last time, AND planemo test --biocontainers passes no problem.

Copy link
Copy Markdown
Contributor

@SaimMomin12 SaimMomin12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Comment thread tools/fastga/alnchain.xml Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants