Skip to content

Adding dynamodb support to get_resources in resourcegroupstagging api#7460

Closed
ppapishe wants to merge 5 commits intogetmoto:masterfrom
ppapishe:add_ddb_support
Closed

Adding dynamodb support to get_resources in resourcegroupstagging api#7460
ppapishe wants to merge 5 commits intogetmoto:masterfrom
ppapishe:add_ddb_support

Conversation

@ppapishe
Copy link
Copy Markdown
Contributor

Currently, mock_resourcegroupstagging is not able to get the dynamodb tables created using mock_dynamodb. This PR is to add that support.

@ppapishe ppapishe marked this pull request as draft March 12, 2024 02:36
@ppapishe ppapishe marked this pull request as ready for review March 13, 2024 00:01
@ppapishe
Copy link
Copy Markdown
Contributor Author

@bblommers , Please review the PR.

I am not sure why the previous merge messed the format. Now the make format basically removing the empty lines in all the files.

@bblommers
Copy link
Copy Markdown
Collaborator

Hi @ppapishe! What version of black are you using? It has to be black==22.3.0 - formatting it with another version would explain these changes.

I think the actual change looks fine, but I would like to see them on their own - so without the formatting stuff. 🙂

@ppapishe
Copy link
Copy Markdown
Contributor Author

Hi @ppapishe! What version of black are you using? It has to be black==22.3.0 - formatting it with another version would explain these changes.

I think the actual change looks fine, but I would like to see them on their own - so without the formatting stuff. 🙂

let me fix that.

@ppapishe
Copy link
Copy Markdown
Contributor Author

Hi @ppapishe! What version of black are you using? It has to be black==22.3.0 - formatting it with another version would explain these changes.
I think the actual change looks fine, but I would like to see them on their own - so without the formatting stuff. 🙂

let me fix that.

@bblommers create a new PR was easier and faster
#7471

Closing this PR. Thanks for the comment

@ppapishe ppapishe closed this Mar 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants